Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: content/browser/frame_host/navigator.h

Issue 1080143003: Move DidStartLoading, DidStopLoading, DidChangeLoadProgress to RFHI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Add delegate accessor from Navigator + Re-add scoped trackers Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index 7390426a8d41a72b0c59c68d440a1ba678270dde..58ffd536ec57b3214cdc4bad9a2f928b6d559fac 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -7,6 +7,7 @@
#include "base/memory/ref_counted.h"
#include "base/time/time.h"
+#include "content/browser/frame_host/navigator_delegate.h"
#include "content/common/content_export.h"
#include "content/public/browser/navigation_controller.h"
#include "ui/base/window_open_disposition.h"
@@ -26,7 +27,6 @@ class FrameTreeNode;
class NavigationControllerImpl;
class NavigationEntryImpl;
class NavigationRequest;
-class NavigatorDelegate;
class RenderFrameHostImpl;
class ResourceRequestBody;
class StreamHandle;
@@ -88,7 +88,6 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
FrameTreeNode* frame_tree_node,
NavigationController::ReloadType reload_type);
-
// Navigation requests -------------------------------------------------------
virtual base::TimeTicks GetCurrentLoadStart();
@@ -167,6 +166,9 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
// event to execute in the renderer process.
virtual bool IsWaitingForBeforeUnloadACK(FrameTreeNode* frame_tree_node);
+ // Returns the delegate of this Navigator.
+ virtual NavigatorDelegate* GetDelegate();
nasko 2015/04/15 19:17:05 nit: I'd move this method right next to the GetCon
Charlie Reis 2015/04/15 23:37:53 +1, and I'd put it before GetController.
Fabrice (no longer in Chrome) 2015/04/16 13:55:25 Done.
+
protected:
friend class base::RefCounted<Navigator>;
virtual ~Navigator() {}

Powered by Google App Engine
This is Rietveld 408576698