content/browser/frame_host/interstitial_page_navigator_impl.h - Issue 1080143003: Move DidStartLoading, DidStopLoading, DidChangeLoadProgress to RFHI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/interstitial_page_navigator_impl.h

Issue 1080143003: Move DidStartLoading, DidStopLoading, DidChangeLoadProgress to RFHI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Add delegate accessor from Navigator + Re-add scoped trackers Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/frame_tree_node.cc ('K') | « content/browser/frame_host/frame_tree_node.cc ('k') | content/browser/frame_host/interstitial_page_navigator_impl.cc » ('j') | content/browser/frame_host/navigator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/interstitial_page_navigator_impl.h

diff --git a/content/browser/frame_host/interstitial_page_navigator_impl.h b/content/browser/frame_host/interstitial_page_navigator_impl.h

index 2f9661440c0ff8c21e6655ee8e5acb81630022f2..27d79bc4c9a8ab213b9c1d19132e4c20d4f17353 100644

--- a/content/browser/frame_host/interstitial_page_navigator_impl.h

+++ b/content/browser/frame_host/interstitial_page_navigator_impl.h

@@ -23,6 +23,7 @@ class CONTENT_EXPORT InterstitialPageNavigatorImpl : public Navigator {

NavigationControllerImpl* navigation_controller);

NavigationController* GetController() override;

+ NavigatorDelegate* GetDelegate() override;

Charlie Reis 2015/04/15 23:37:53 nit: Should come first.

Fabrice (no longer in Chrome) 2015/04/16 13:55:25 Done.

void DidNavigate(RenderFrameHostImpl* render_frame_host,

const FrameHostMsg_DidCommitProvisionalLoad_Params&

input_params) override;