Move DidStartLoading, DidStopLoading, DidChangeLoadProgress to RFHI.

content/browser/frame_host/frame_tree_node.h

Index: content/browser/frame_host/frame_tree_node.h
diff --git a/content/browser/frame_host/frame_tree_node.h b/content/browser/frame_host/frame_tree_node.h
index 30843d8f2723c8663f30370e980322f67fa3724d..66a1497fbc774cb7cbdc5aef04974ba8c956a6b1 100644
--- a/content/browser/frame_host/frame_tree_node.h
+++ b/content/browser/frame_host/frame_tree_node.h
@@ -30,15 +30,6 @@ class RenderFrameHostImpl;
 // are frame-specific (as opposed to page-specific).
 class CONTENT_EXPORT FrameTreeNode {
  public:
-  // These values indicate the loading progress status. The minimum progress
-  // value matches what Blink's ProgressTracker has traditionally used for a
-  // minimum progress value.
-  // TODO(fdegans): Move these values to the implementation when the relevant
-  // IPCs are moved from WebContentsImpl to RenderFrameHost.
-  static const double kLoadingProgressNotStarted;
-  static const double kLoadingProgressMinimum;
-  static const double kLoadingProgressDone;
-
   // Returns the FrameTreeNode with the given global |frame_tree_node_id|,
   // regardless of which FrameTree it is in.
   static FrameTreeNode* GloballyFindByID(int64 frame_tree_node_id);
@@ -134,14 +125,27 @@ class CONTENT_EXPORT FrameTreeNode {
   // Returns true if this node is in a loading state.
   bool IsLoading() const;
 
-  // Sets this node's loading progress (from 0 to 1).
-  void set_loading_progress(double loading_progress) {
-    loading_progress_ = loading_progress;
-  }
-
   // Returns this node's loading progress.
   double loading_progress() const { return loading_progress_; }
 
+  // Returns true if this node has started loading.
+  bool HasStartedLoading() const;

[Charlie Reis, 2015/04/15 23:37:53]

This is easily confused with IsLoading() above.  Can you clarify the difference
between them so that callers know which one to use?

[Fabrice (no longer in Chrome), 2015/04/16 13:55:25]

I rephrased the comment. WDYT?

[Charlie Reis, 2015/04/16 17:37:05]

Sounds good, thanks.

+
+  // Resets this node's loading progress.
+  void ResetLoadingProgress();
+
+  // A RenderFrame in this node started loading.

[Charlie Reis, 2015/04/15 23:37:53]

We're in the browser process, so let's say RenderFrameHost.  Same below.

[Fabrice (no longer in Chrome), 2015/04/16 13:55:25]

Done.

+  // |to_different_document| will be true unless the load is a fragment
+  // navigation, or triggered by history.pushState/replaceState.
+  void DidStartLoading(bool to_different_document);
+
+  // A RenderFrame in this node stopped loading.
+  void DidStopLoading();
+
+  // The load progress for a RenderFrame in this node was updated to
+  // |load_progress|.
+  void DidChangeLoadProgress(double load_progress);
+
  private:
   void set_parent(FrameTreeNode* parent) { parent_ = parent; }