Move DidStartLoading, DidStopLoading, DidChangeLoadProgress to RFHI.

content/browser/frame_host/frame_tree_node.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
 #define CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 12 matching lines @@
 class FrameTree;
 class Navigator;
 class RenderFrameHostImpl;
 
 // When a page contains iframes, its renderer process maintains a tree structure
 // of those frames. We are mirroring this tree in the browser process. This
 // class represents a node in this tree and is a wrapper for all objects that
 // are frame-specific (as opposed to page-specific).
 class CONTENT_EXPORT FrameTreeNode {
  public:
-  // These values indicate the loading progress status. The minimum progress
-  // value matches what Blink's ProgressTracker has traditionally used for a
-  // minimum progress value.
-  // TODO(fdegans): Move these values to the implementation when the relevant
-  // IPCs are moved from WebContentsImpl to RenderFrameHost.
-  static const double kLoadingProgressNotStarted;
-  static const double kLoadingProgressMinimum;
-  static const double kLoadingProgressDone;
-
   // Returns the FrameTreeNode with the given global |frame_tree_node_id|,
   // regardless of which FrameTree it is in.
   static FrameTreeNode* GloballyFindByID(int64 frame_tree_node_id);
 
   FrameTreeNode(FrameTree* frame_tree,
                 Navigator* navigator,
                 RenderFrameHostDelegate* render_frame_delegate,
                 RenderViewHostDelegate* render_view_delegate,
                 RenderWidgetHostDelegate* render_widget_delegate,
                 RenderFrameHostManager::Delegate* manager_delegate,
@@ skipping 75 matching lines @@
 
   RenderFrameHostImpl* current_frame_host() const {
     return render_manager_.current_frame_host();
   }
 
   bool IsDescendantOf(FrameTreeNode* other) const;
 
   // Returns true if this node is in a loading state.
   bool IsLoading() const;
 
-  // Sets this node's loading progress (from 0 to 1).
-  void set_loading_progress(double loading_progress) {
-    loading_progress_ = loading_progress;
-  }
-
   // Returns this node's loading progress.
   double loading_progress() const { return loading_progress_; }
 
+  // Returns true if this node has started loading.
+  bool HasStartedLoading() const;

[Charlie Reis, 2015/04/15 23:37:53]

This is easily confused with IsLoading() above.  Can you clarify the difference
between them so that callers know which one to use?

[Fabrice (no longer in Chrome), 2015/04/16 13:55:25]

I rephrased the comment. WDYT?

[Charlie Reis, 2015/04/16 17:37:05]

Sounds good, thanks.

+
+  // Resets this node's loading progress.
+  void ResetLoadingProgress();
+
+  // A RenderFrame in this node started loading.

[Charlie Reis, 2015/04/15 23:37:53]

We're in the browser process, so let's say RenderFrameHost.  Same below.

[Fabrice (no longer in Chrome), 2015/04/16 13:55:25]

Done.

+  // |to_different_document| will be true unless the load is a fragment
+  // navigation, or triggered by history.pushState/replaceState.
+  void DidStartLoading(bool to_different_document);
+
+  // A RenderFrame in this node stopped loading.
+  void DidStopLoading();
+
+  // The load progress for a RenderFrame in this node was updated to
+  // |load_progress|.
+  void DidChangeLoadProgress(double load_progress);
+
  private:
   void set_parent(FrameTreeNode* parent) { parent_ = parent; }
 
   // The next available browser-global FrameTreeNode ID.
   static int64 next_frame_tree_node_id_;
 
   // The FrameTree that owns us.
   FrameTree* frame_tree_;  // not owned.
 
   // The Navigator object responsible for managing navigations at this node
@@ skipping 39 matching lines @@
 
   // Used to track this node's loading progress (from 0 to 1).
   double loading_progress_;
 
   DISALLOW_COPY_AND_ASSIGN(FrameTreeNode);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_