Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1080143002: Disable ExtensionsStartupTest.* (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Xi Han
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ExtensionsStartupTest.* The two tests time out in official tests. Extension folks say that the test design is incorrect and that the test needs to be rewritten. Since these are the only two tests keeping a bot red that runs tests in buildtype=Official branding=Chrome, disable them so that we can find new regressions. The extensions team can fix this test asynchronously. BUG=474659, 48151 R=rdevlin.cronin@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/9ce471d449a9b7ebb0ecf3b3af82663475e0b886

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 8 months ago (2015-04-13 20:38:37 UTC) #2
Devlin
lgtm
5 years, 8 months ago (2015-04-13 20:40:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080143002/1
5 years, 8 months ago (2015-04-13 20:42:28 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9ce471d449a9b7ebb0ecf3b3af82663475e0b886 Cr-Commit-Position: refs/heads/master@{#324914}
5 years, 8 months ago (2015-04-13 20:56:45 UTC) #6
Nico
5 years, 8 months ago (2015-04-13 20:57:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9ce471d449a9b7ebb0ecf3b3af82663475e0b886 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698