Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2016)

Unified Diff: chrome/browser/extensions/extension_startup_browsertest.cc

Issue 1080143002: Disable ExtensionsStartupTest.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_startup_browsertest.cc
diff --git a/chrome/browser/extensions/extension_startup_browsertest.cc b/chrome/browser/extensions/extension_startup_browsertest.cc
index d61a48d2aa17b72cd754a39d0cc595a9c64eee85..90acea6323e4885959a8688ee4b16c31b1b0236e 100644
--- a/chrome/browser/extensions/extension_startup_browsertest.cc
+++ b/chrome/browser/extensions/extension_startup_browsertest.cc
@@ -198,20 +198,17 @@ class ExtensionStartupTestBase : public InProcessBrowserTest {
// extensions installed and see them run and do basic things.
typedef ExtensionStartupTestBase ExtensionsStartupTest;
-IN_PROC_BROWSER_TEST_F(ExtensionsStartupTest, Test) {
+// Broken in official builds, http://crbug.com/474659
+IN_PROC_BROWSER_TEST_F(ExtensionsStartupTest, DISABLED_Test) {
WaitForServicesToStart(num_expected_extensions_, true);
TestInjection(true, true);
}
+// Broken in official builds, http://crbug.com/474659
// Sometimes times out on Mac. http://crbug.com/48151
-#if defined(OS_MACOSX)
-#define MAYBE_NoFileAccess DISABLED_NoFileAccess
-#else
-#define MAYBE_NoFileAccess NoFileAccess
-#endif
// Tests that disallowing file access on an extension prevents it from injecting
// script into a page with a file URL.
-IN_PROC_BROWSER_TEST_F(ExtensionsStartupTest, MAYBE_NoFileAccess) {
+IN_PROC_BROWSER_TEST_F(ExtensionsStartupTest, DISABLED_NoFileAccess) {
WaitForServicesToStart(num_expected_extensions_, true);
// Keep a separate list of extensions for which to disable file access, since
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698