Build Autofill component on iOS.

Build Autofill component on iOS.

This change builds the core code of //component/autofill as well as its core
unittests on iOS. The iOS driver of the Autofill component will be landed at a
later date.

BUG=302428, 303079
TBR=joi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240504

[blundell, 2013-12-11 20:42:21]

This CL is dependent on https://codereview.chromium.org/108283005/.

[Ilya Sherman, 2013-12-11 22:50:38]

https://codereview.chromium.org/108013004/diff/1/components/autofill.gypi
File components/autofill.gypi (right):

https://codereview.chromium.org/108013004/diff/1/components/autofill.gypi#new...
components/autofill.gypi:53:
'autofill/core/browser/android/personal_data_manager_android.cc',
Hmm, why are these under core_common?

https://codereview.chromium.org/108013004/diff/1/components/autofill.gypi#new...
components/autofill.gypi:238: },
Are there any changes in any of the lines in this file, or did you just move
them?

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/credit_card.cc (right):

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
components/autofill/core/browser/credit_card.cc:32: #if !defined(OS_IOS)
nit: Please include a TODO + bug for this as well.

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
components/autofill/core/browser/credit_card.cc:172: // need for this ifdef-ing.
Please file a bug for this and include a link here.

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
components/autofill/core/browser/credit_card.cc:195: #endif
nit: "#endif  // defined(OS_IOS)"

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/personal_data_manager.cc (right):

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
components/autofill/core/browser/personal_data_manager.cc:871: #if
defined(OS_IOS) || (!defined(OS_MACOSX) && !defined(OS_ANDROID))
Why are changes to this line needed?  Does OS_IOS also cause OS_MACOSX to be
defined?

[blundell, 2013-12-12 20:53:54]

Thanks! PS #2 is a rebase onto origin/master after JF's IPC CL landed. The
response to the review is the diff between PS #2 and PS #3.

This is an exciting CL :).

https://codereview.chromium.org/108013004/diff/1/components/autofill.gypi
File components/autofill.gypi (right):

https://codereview.chromium.org/108013004/diff/1/components/autofill.gypi#new...
components/autofill.gypi:53:
'autofill/core/browser/android/personal_data_manager_android.cc',
Whoa, bizarre! I'll fix this when I do the fix for crbug.com/318768. I'd prefer
not to touch it as part of this CL for separation of concerns.

On 2013/12/11 22:50:38, Ilya Sherman wrote:
> Hmm, why are these under core_common?

https://codereview.chromium.org/108013004/diff/1/components/autofill.gypi#new...
components/autofill.gypi:238: },
The only change is to make the dependency on webkit_resources from
autofill_core_browser conditional on !iOS. I've added a TODO and bug reference
there now.

On 2013/12/11 22:50:38, Ilya Sherman wrote:
> Are there any changes in any of the lines in this file, or did you just move
> them?

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/credit_card.cc (right):

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
components/autofill/core/browser/credit_card.cc:32: #if !defined(OS_IOS)
On 2013/12/11 22:50:38, Ilya Sherman wrote:
> nit: Please include a TODO + bug for this as well.

Done.

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
components/autofill/core/browser/credit_card.cc:172: // need for this ifdef-ing.
On 2013/12/11 22:50:38, Ilya Sherman wrote:
> Please file a bug for this and include a link here.

Done.

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
components/autofill/core/browser/credit_card.cc:195: #endif
On 2013/12/11 22:50:38, Ilya Sherman wrote:
> nit: "#endif  // defined(OS_IOS)"

Done.

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/personal_data_manager.cc (right):

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
components/autofill/core/browser/personal_data_manager.cc:871: #if
defined(OS_IOS) || (!defined(OS_MACOSX) && !defined(OS_ANDROID))
OS_IOS does indeed cause OS_MACOSX to be defined (it's done this way because it
follows the way that Apple manages its defines).

On 2013/12/11 22:50:38, Ilya Sherman wrote:
> Why are changes to this line needed?  Does OS_IOS also cause OS_MACOSX to be
> defined?

[Ilya Sherman, 2013-12-12 22:34:52]

LGTM, thanks.  Super exciting closing in on the finish line! :)

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/personal_data_manager.cc (right):

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
components/autofill/core/browser/personal_data_manager.cc:871: #if
defined(OS_IOS) || (!defined(OS_MACOSX) && !defined(OS_ANDROID))
Ok, good to know!  Might be worth adding a comment here to that effect, since
that's not obvious to most people not familiar with the OS defines.  Though,
maybe it's not worth it, because adding such comments everywhere where they are
relevant might result in the entire codebase littered with lots of repetitive
comments.  Up to your discretion, I guess.

On 2013/12/12 20:53:54, blundell wrote:
> OS_IOS does indeed cause OS_MACOSX to be defined (it's done this way because
it
> follows the way that Apple manages its defines).
> 
> On 2013/12/11 22:50:38, Ilya Sherman wrote:
> > Why are changes to this line needed?  Does OS_IOS also cause OS_MACOSX to be
> > defined?

[blundell, 2013-12-12 22:41:29]

Thanks for all the reviews during this process!

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/personal_data_manager.cc (right):

https://codereview.chromium.org/108013004/diff/1/components/autofill/core/bro...
components/autofill/core/browser/personal_data_manager.cc:871: #if
defined(OS_IOS) || (!defined(OS_MACOSX) && !defined(OS_ANDROID))
I don't think that we comment this in general.

On 2013/12/12 22:34:52, Ilya Sherman wrote:
> Ok, good to know!  Might be worth adding a comment here to that effect, since
> that's not obvious to most people not familiar with the OS defines.  Though,
> maybe it's not worth it, because adding such comments everywhere where they
are
> relevant might result in the entire codebase littered with lots of repetitive
> comments.  Up to your discretion, I guess.
> 
> On 2013/12/12 20:53:54, blundell wrote:
> > OS_IOS does indeed cause OS_MACOSX to be defined (it's done this way because
> it
> > follows the way that Apple manages its defines).
> > 
> > On 2013/12/11 22:50:38, Ilya Sherman wrote:
> > > Why are changes to this line needed?  Does OS_IOS also cause OS_MACOSX to
be
> > > defined?

[blundell, 2013-12-12 22:42:20]

TBR: joi@ for components/components_tests.gyp

[commit-bot: I haz the power, 2013-12-12 22:44:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/108013004/40001

[commit-bot: I haz the power, 2013-12-13 00:53:05]

Change committed as 240504

[tfarina, 2014-07-30 03:36:37]

https://codereview.chromium.org/108013004/diff/40001/components/autofill.gypi
File components/autofill.gypi (right):

https://codereview.chromium.org/108013004/diff/40001/components/autofill.gypi...
components/autofill.gypi:47:
'autofill/core/browser/android/auxiliary_profile_loader_android.cc',
Ilya, Colin, why are these browser files in this common target?

I was looking at the TODO and saw it in the GN Build file:
https://chromium.googlesource.com/chromium/src/+/master/components/autofill/c...

[Ilya Sherman, 2014-07-30 20:28:01]

https://codereview.chromium.org/108013004/diff/40001/components/autofill.gypi
File components/autofill.gypi (right):

https://codereview.chromium.org/108013004/diff/40001/components/autofill.gypi...
components/autofill.gypi:47:
'autofill/core/browser/android/auxiliary_profile_loader_android.cc',
On 2014/07/30 03:36:37, tfarina wrote:
> Ilya, Colin, why are these browser files in this common target?
> 
> I was looking at the TODO and saw it in the GN Build file:
>
https://chromium.googlesource.com/chromium/src/+/master/components/autofill/c...
> 

Huh, that's a great question.  I bet it was an oversight, and they should be
moved to the browser target.

[blundell, 2014-08-06 08:58:57]

https://codereview.chromium.org/108013004/diff/40001/components/autofill.gypi
File components/autofill.gypi (right):

https://codereview.chromium.org/108013004/diff/40001/components/autofill.gypi...
components/autofill.gypi:47:
'autofill/core/browser/android/auxiliary_profile_loader_android.cc',
Yeah, seems like a bug.

On 2014/07/30 20:28:01, Ilya Sherman wrote:
> On 2014/07/30 03:36:37, tfarina wrote:
> > Ilya, Colin, why are these browser files in this common target?
> > 
> > I was looking at the TODO and saw it in the GN Build file:
> >
>
https://chromium.googlesource.com/chromium/src/+/master/components/autofill/c...
> > 
> 
> Huh, that's a great question.  I bet it was an oversight, and they should be
> moved to the browser target.