Chromium Code Reviews
Help | Chromium Project | Sign in
(811)

Issue 108013004: Build Autofill component on iOS. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by blundell (OOO until April 28)
Modified:
4 months, 1 week ago
Reviewers:
Ilya Sherman, Jói
CC:
chromium-reviews_chromium.org, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_autofill_ipc
Visibility:
Public.

Description

Build Autofill component on iOS.

This change builds the core code of //component/autofill as well as its core
unittests on iOS. The iOS driver of the Autofill component will be landed at a
later date.

BUG=302428, 303079
TBR=joi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240504

Patch Set 1 #

Total comments: 14

Patch Set 2 : Rebase #

Patch Set 3 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -219 lines) Lint Patch
M build/ios/grit_whitelist.txt View 1 chunk +1 line, -0 lines 0 comments ? errors Download
M components/autofill.gypi View 1 2 2 chunks +216 lines, -211 lines 0 comments ? errors Download
M components/autofill/core/browser/credit_card.cc View 1 2 3 chunks +13 lines, -1 line 0 comments 1 errors Download
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +3 lines, -3 lines 0 comments 0 errors Download
M components/components_tests.gyp View 1 3 chunks +6 lines, -4 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 8
blundell (OOO until April 28)
This CL is dependent on https://codereview.chromium.org/108283005/.
4 months, 1 week ago #1
Ilya Sherman
https://codereview.chromium.org/108013004/diff/1/components/autofill.gypi File components/autofill.gypi (right): https://codereview.chromium.org/108013004/diff/1/components/autofill.gypi#newcode53 components/autofill.gypi:53: 'autofill/core/browser/android/personal_data_manager_android.cc', Hmm, why are these under core_common? https://codereview.chromium.org/108013004/diff/1/components/autofill.gypi#newcode238 components/autofill.gypi:238: ...
4 months, 1 week ago #2
blundell (OOO until April 28)
Thanks! PS #2 is a rebase onto origin/master after JF's IPC CL landed. The response ...
4 months, 1 week ago #3
Ilya Sherman
LGTM, thanks. Super exciting closing in on the finish line! :) https://codereview.chromium.org/108013004/diff/1/components/autofill/core/browser/personal_data_manager.cc File components/autofill/core/browser/personal_data_manager.cc (right): ...
4 months, 1 week ago #4
blundell (OOO until April 28)
Thanks for all the reviews during this process! https://codereview.chromium.org/108013004/diff/1/components/autofill/core/browser/personal_data_manager.cc File components/autofill/core/browser/personal_data_manager.cc (right): https://codereview.chromium.org/108013004/diff/1/components/autofill/core/browser/personal_data_manager.cc#newcode871 components/autofill/core/browser/personal_data_manager.cc:871: #if ...
4 months, 1 week ago #5
blundell (OOO until April 28)
TBR: joi@ for components/components_tests.gyp
4 months, 1 week ago #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/108013004/40001
4 months, 1 week ago #7
I haz the power (commit-bot)
4 months, 1 week ago #8
Message was sent while issue was closed.
Change committed as 240504
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6