Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1080113004: Enable tessellating GPU path renderer. (Closed)

Created:
5 years, 8 months ago by Stephen White
Modified:
5 years, 8 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable tessellating GPU path renderer. This also contains a fix to remove recursion from the sorted_merge() step. This was essentially tail-recursion, and was causing stack exhaustion on some platforms. Making it iterative fixes the issue. Note: this CL will affect a large number of GPU GM results. R=bsalomon@google.com BUG= Committed: https://skia.googlesource.com/skia/+/7ef63c85c5891ca59906e3c783a7f954be3f7f62

Patch Set 1 #

Patch Set 2 : Remove some now-useless code #

Patch Set 3 : Add back enable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M src/gpu/GrAddPathRenderers_default.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 1 chunk +27 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Stephen White
Brian: PTAL. Thanks!
5 years, 8 months ago (2015-04-13 21:00:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080113004/20001
5 years, 8 months ago (2015-04-13 21:00:17 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 21:00:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080113004/40001
5 years, 8 months ago (2015-04-13 21:02:06 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 21:02:06 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-13 21:16:43 UTC) #9
bsalomon
lgtm
5 years, 8 months ago (2015-04-13 21:26:12 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 21:27:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7ef63c85c5891ca59906e3c783a7f954be3f7f62

Powered by Google App Engine
This is Rietveld 408576698