Add brightness/grayscale animations and use them for OOBE boot transition

Add brightness/grayscale animations and use them for OOBE boot transition.
Add support for both boot up/boot down animations.

Checked, looks fine on x86-alex, stumpy.

BUG=133279
TEST=LayerAnimatorTest.[GetTargetBrightness|GetTargetGrayscale], LayerAnimationElementTest.[BrightnessElement|GrayscaleElement], WindowAnimationsTest.HideShowBrightnessGrayscaleAnimation

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147786

[Nikita (slow), 2012-07-19 16:06:48]

Please review, 
most of the diff is exposing brightness and grayscale properties/animations the
same way opacity is exposed. 

See issue for css mock. 

bshe@ - wallpaper related changes 
sky@ - whole CL

[Nikita (slow), 2012-07-19 16:22:32]

CSS mock: 

I'm adding effect that is seen on mouse hover for first block.

That might be later a bit refactored to support backward effect (i.e. seen on
device shut down) but first I want to confirm that we really want that effect on
machine shutdown as it takes 2 seconds while current shutdown effect is just a
matter of hundred milliseconds.

But that refactoring is just a matter of setting initial/final
brightness/grayscale values.

[Nikita (slow), 2012-07-19 16:25:35]

CSS mock https://crwm.googleplex.com/lab/boot/boot.html

[sky, 2012-07-19 19:22:19]

Can you add test coverage too.

http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.c...
ash/wm/window_animations.cc:73: const int kBrightnessGrayscaleFadeDurationMs =
2000;
This is a really long time. Are you sure we want 2seconds?

http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.c...
ash/wm/window_animations.cc:527: case
WINDOW_VISIBILITY_ANIMATION_TYPE_BRIGHTNESS_GRAYSCALE:
What about the hide case?

[bshe, 2012-07-19 20:43:38]

wallpaper lgtm with nit

http://codereview.chromium.org/10800020/diff/14001/ash/desktop_background/des...
File ash/desktop_background/desktop_background_controller.h (right):

http://codereview.chromium.org/10800020/diff/14001/ash/desktop_background/des...
ash/desktop_background/desktop_background_controller.h:28: // Returns type of
window animation that should be used when showin wallpaper.
nit: showin=>showing

[Nikita (slow), 2012-07-19 20:46:22]

On 2012/07/19 19:22:19, sky wrote:
> Can you add test coverage too.

Sure, I'll add couple of usages of new animations properties in compositor
unittests tomorrow.
Scott, could you please take a look if you have any other comments for this CL
so that I might fix those as well?

> 
> http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.cc
> File ash/wm/window_animations.cc (right):
> 
>
http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.c...
> ash/wm/window_animations.cc:73: const int kBrightnessGrayscaleFadeDurationMs =
> 2000;
> This is a really long time. Are you sure we want 2seconds?
> 
>
http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.c...
> ash/wm/window_animations.cc:527: case
> WINDOW_VISIBILITY_ANIMATION_TYPE_BRIGHTNESS_GRAYSCALE:
> What about the hide case?

[Nikita (slow), 2012-07-19 20:47:08]

http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.c...
ash/wm/window_animations.cc:73: const int kBrightnessGrayscaleFadeDurationMs =
2000;
On 2012/07/19 19:22:19, sky wrote:
> This is a really long time. Are you sure we want 2seconds?

Yes, that what it should look like according to mocks.
Faster transition would look worse.

This transition is only used couple of times:
- First OOBE boot
- OOBE boot after update reboot
- Any other boot till user signs in at least once (existing user / guest) i.e.
finishes OOBE.

http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.c...
ash/wm/window_animations.cc:527: case
WINDOW_VISIBILITY_ANIMATION_TYPE_BRIGHTNESS_GRAYSCALE:
On 2012/07/19 19:22:19, sky wrote:
> What about the hide case?

Yes, I might refactor code a bit to support reverse animation i.e. hide but I'm
still not sure we'd be using it. But I'll do that just in case.

[sky, 2012-07-19 21:33:27]

I did, that is the only comment I had.

  -Scott
On Thu, Jul 19, 2012 at 1:46 PM,  <nkostylev@chromium.org> wrote:
> On 2012/07/19 19:22:19, sky wrote:
>>
>> Can you add test coverage too.
>
>
> Sure, I'll add couple of usages of new animations properties in compositor
> unittests tomorrow.
> Scott, could you please take a look if you have any other comments for this
> CL
> so that I might fix those as well?
>
>
>
>>
>>
http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.cc
>> File ash/wm/window_animations.cc (right):
>
>
>
>
http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.c...
>>
>> ash/wm/window_animations.cc:73: const int
>> kBrightnessGrayscaleFadeDurationMs =
>> 2000;
>> This is a really long time. Are you sure we want 2seconds?
>
>
>
>
http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.c...
>>
>> ash/wm/window_animations.cc:527: case
>> WINDOW_VISIBILITY_ANIMATION_TYPE_BRIGHTNESS_GRAYSCALE:
>> What about the hide case?
>
>
>
>
> http://codereview.chromium.org/10800020/

[Nikita (slow), 2012-07-20 18:21:28]

http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.c...
ash/wm/window_animations.cc:73: const int kBrightnessGrayscaleFadeDurationMs =
2000;
On 2012/07/19 19:22:19, sky wrote:
> This is a really long time. Are you sure we want 2seconds?

Confirmed with UX.

http://codereview.chromium.org/10800020/diff/14001/ash/wm/window_animations.c...
ash/wm/window_animations.cc:527: case
WINDOW_VISIBILITY_ANIMATION_TYPE_BRIGHTNESS_GRAYSCALE:
On 2012/07/19 19:22:19, sky wrote:
> What about the hide case?

Done.

[Nikita (slow), 2012-07-20 18:22:55]

On 2012/07/19 19:22:19, sky wrote:
> Can you add test coverage too.

Done.

[sky, 2012-07-20 23:35:07]

LGTM

[commit-bot: I haz the power, 2012-07-21 06:20:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10800020/31

[commit-bot: I haz the power, 2012-07-21 08:13:46]

Change committed as 147786