Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1079983003: Move WebDevice{Motion|Orientation} related Blink API headers into their own (Closed)

Created:
5 years, 8 months ago by riju_
Modified:
5 years, 7 months ago
CC:
abarth-chromium, blink-reviews, Inactive, dglazkov+blink, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move WebDevice{Motion|Orientation} related Blink API headers into their own directory. This allows the WebDevice{Motion|Orientation} APIs to be covered by a motion|orientation owner on top of the other public/ OWNERS This is a part of a 3 sided patch: [1] This patch [2] https://codereview.chromium.org/1093433005/ [3] https://codereview.chromium.org/1106933002/ BUG=453032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194583

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove unused header files #

Total comments: 2

Patch Set 3 : git cl upload --no-find-copies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -265 lines) Patch
M Source/modules/device_orientation/DeviceMotionData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionDispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationDispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebDeviceMotionData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebDeviceOrientationData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/Platform.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebDeviceMotionData.h View 1 chunk +1 line, -86 lines 0 comments Download
M public/platform/WebDeviceMotionListener.h View 1 chunk +1 line, -50 lines 0 comments Download
M public/platform/WebDeviceOrientationData.h View 1 chunk +1 line, -71 lines 0 comments Download
M public/platform/WebDeviceOrientationListener.h View 1 chunk +1 line, -50 lines 0 comments Download
A public/platform/modules/device_orientation/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A public/platform/modules/device_orientation/WebDeviceMotionData.h View 1 2 1 chunk +86 lines, -0 lines 0 comments Download
A public/platform/modules/device_orientation/WebDeviceMotionListener.h View 1 2 1 chunk +50 lines, -0 lines 0 comments Download
A public/platform/modules/device_orientation/WebDeviceOrientationData.h View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
A public/platform/modules/device_orientation/WebDeviceOrientationListener.h View 1 2 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
riju_
Hi Tim, just a mechanical change, but saw other modules doing it
5 years, 8 months ago (2015-04-22 10:33:28 UTC) #2
timvolodine
https://codereview.chromium.org/1079983003/diff/1/public/platform/Platform.h File public/platform/Platform.h (right): https://codereview.chromium.org/1079983003/diff/1/public/platform/Platform.h#newcode56 public/platform/Platform.h:56: #include "public/platform/modules/device_orientation/WebDeviceMotionListener.h" could you provide some pointers to similar ...
5 years, 8 months ago (2015-04-23 14:48:47 UTC) #3
riju_
tim@ PTAL. https://codereview.chromium.org/1079983003/diff/1/public/platform/Platform.h File public/platform/Platform.h (right): https://codereview.chromium.org/1079983003/diff/1/public/platform/Platform.h#newcode56 public/platform/Platform.h:56: #include "public/platform/modules/device_orientation/WebDeviceMotionListener.h" On 2015/04/23 14:48:47, timvolodine wrote: ...
5 years, 8 months ago (2015-04-24 12:12:05 UTC) #4
timvolodine
okay is fine with me, could you please upload with --no-find-copies and change the issue ...
5 years, 8 months ago (2015-04-24 13:00:35 UTC) #5
riju_
thanks tim@. https://codereview.chromium.org/1079983003/diff/20001/Source/platform/exported/WebDeviceMotionData.cpp File Source/platform/exported/WebDeviceMotionData.cpp (right): https://codereview.chromium.org/1079983003/diff/20001/Source/platform/exported/WebDeviceMotionData.cpp#newcode2 Source/platform/exported/WebDeviceMotionData.cpp:2: * Copyright (C) 2013 Google Inc. All ...
5 years, 8 months ago (2015-04-24 13:20:59 UTC) #6
timvolodine
lgtm
5 years, 8 months ago (2015-04-24 13:45:15 UTC) #7
riju_
mike@, jochen@: Source/platform and public/platform
5 years, 7 months ago (2015-04-27 07:52:34 UTC) #9
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-04-27 19:36:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079983003/40001
5 years, 7 months ago (2015-04-28 06:17:52 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 08:36:35 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194583

Powered by Google App Engine
This is Rietveld 408576698