Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 1079973002: [Source/core/animation] Use Local<> in lieu of Handle<> (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 8 months ago
Reviewers:
haraken, Timothy Loh
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use Local<> in lieu of Handle<> for the Source/core/animation Use Local<> in lieu of Handle<> for the Source/core/animation BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193673

Patch Set 1 #

Patch Set 2 : Fixed build breaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M Source/core/animation/AnimationTest.cpp View 10 chunks +15 lines, -15 lines 0 comments Download
M Source/core/animation/EffectInputTest.cpp View 5 chunks +14 lines, -14 lines 0 comments Download
M Source/core/animation/TimingInputTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
anujsharma
PTAL
5 years, 8 months ago (2015-04-14 05:46:52 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-14 05:48:13 UTC) #3
anujsharma
On 2015/04/14 05:48:13, haraken wrote: > LGTM Thanks haraken for lgtm
5 years, 8 months ago (2015-04-14 05:49:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079973002/20001
5 years, 8 months ago (2015-04-14 05:49:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=193673
5 years, 8 months ago (2015-04-14 07:22:09 UTC) #7
Timothy Loh
Please don't remove the automatically added cc-ed people and lists.
5 years, 8 months ago (2015-04-14 07:47:14 UTC) #9
anujsharma
5 years, 8 months ago (2015-04-14 09:34:44 UTC) #10
Message was sent while issue was closed.
On 2015/04/14 07:47:14, Timothy Loh wrote:
> Please don't remove the automatically added cc-ed people and lists.

@Timothy Loh

Actually while uploading, i used "git cl upload --bypass-watchlists". It might
be the reason, cc list got deleted.
But i will take care of this thing in future.
Thanks!!

Powered by Google App Engine
This is Rietveld 408576698