Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: Source/core/animation/EffectInputTest.cpp

Issue 1079973002: [Source/core/animation] Use Local<> in lieu of Handle<> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed build breaks Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/AnimationTest.cpp ('k') | Source/core/animation/TimingInputTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/EffectInputTest.cpp
diff --git a/Source/core/animation/EffectInputTest.cpp b/Source/core/animation/EffectInputTest.cpp
index 6f662214b32ca49d36d2531e341668864ad095b0..51e406e724d90199b372ddcf21ebf35ce266d597 100644
--- a/Source/core/animation/EffectInputTest.cpp
+++ b/Source/core/animation/EffectInputTest.cpp
@@ -41,8 +41,8 @@ private:
TEST_F(AnimationEffectInputTest, SortedOffsets)
{
Vector<Dictionary> jsKeyframes;
- v8::Handle<v8::Object> keyframe1 = v8::Object::New(m_isolate);
- v8::Handle<v8::Object> keyframe2 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe1 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe2 = v8::Object::New(m_isolate);
setV8ObjectPropertyAsString(keyframe1, "width", "100px");
setV8ObjectPropertyAsString(keyframe1, "offset", "0");
@@ -61,8 +61,8 @@ TEST_F(AnimationEffectInputTest, SortedOffsets)
TEST_F(AnimationEffectInputTest, UnsortedOffsets)
{
Vector<Dictionary> jsKeyframes;
- v8::Handle<v8::Object> keyframe1 = v8::Object::New(m_isolate);
- v8::Handle<v8::Object> keyframe2 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe1 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe2 = v8::Object::New(m_isolate);
setV8ObjectPropertyAsString(keyframe1, "width", "0px");
setV8ObjectPropertyAsString(keyframe1, "offset", "1");
@@ -80,9 +80,9 @@ TEST_F(AnimationEffectInputTest, UnsortedOffsets)
TEST_F(AnimationEffectInputTest, LooslySorted)
{
Vector<Dictionary> jsKeyframes;
- v8::Handle<v8::Object> keyframe1 = v8::Object::New(m_isolate);
- v8::Handle<v8::Object> keyframe2 = v8::Object::New(m_isolate);
- v8::Handle<v8::Object> keyframe3 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe1 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe2 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe3 = v8::Object::New(m_isolate);
setV8ObjectPropertyAsString(keyframe1, "width", "100px");
setV8ObjectPropertyAsString(keyframe1, "offset", "0");
@@ -103,10 +103,10 @@ TEST_F(AnimationEffectInputTest, LooslySorted)
TEST_F(AnimationEffectInputTest, OutOfOrderWithNullOffsets)
{
Vector<Dictionary> jsKeyframes;
- v8::Handle<v8::Object> keyframe1 = v8::Object::New(m_isolate);
- v8::Handle<v8::Object> keyframe2 = v8::Object::New(m_isolate);
- v8::Handle<v8::Object> keyframe3 = v8::Object::New(m_isolate);
- v8::Handle<v8::Object> keyframe4 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe1 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe2 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe3 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe4 = v8::Object::New(m_isolate);
setV8ObjectPropertyAsString(keyframe1, "height", "100px");
setV8ObjectPropertyAsString(keyframe1, "offset", "0.5");
@@ -129,9 +129,9 @@ TEST_F(AnimationEffectInputTest, Invalid)
{
// Not loosely sorted by offset, and there exists a keyframe with null offset.
Vector<Dictionary> jsKeyframes;
- v8::Handle<v8::Object> keyframe1 = v8::Object::New(m_isolate);
- v8::Handle<v8::Object> keyframe2 = v8::Object::New(m_isolate);
- v8::Handle<v8::Object> keyframe3 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe1 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe2 = v8::Object::New(m_isolate);
+ v8::Local<v8::Object> keyframe3 = v8::Object::New(m_isolate);
setV8ObjectPropertyAsString(keyframe1, "width", "0px");
setV8ObjectPropertyAsString(keyframe1, "offset", "1");
« no previous file with comments | « Source/core/animation/AnimationTest.cpp ('k') | Source/core/animation/TimingInputTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698