Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1079963002: [Android] Update path to testing AndroidManifest.xml for GN. (Closed)

Created:
5 years, 8 months ago by kjellander_chromium
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Update path to testing AndroidManifest.xml for GN. In https://codereview.chromium.org/1071573003 the testing/android/ directory was moved into testing/android/native_test/ which broke the Opus test_opus_padding target. It's built as part of the 'all' target, which is why it hasn't been noticed (Android GN bots build chrome_shell_apk). Committed: https://crrev.com/ac81bcc78bc4a74dc7e4e473c5833d2aad0103df Cr-Commit-Position: refs/heads/master@{#324836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/android/rules.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
5 years, 8 months ago (2015-04-13 09:59:14 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-13 11:05:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079963002/1
5 years, 8 months ago (2015-04-13 11:18:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 11:21:44 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 11:22:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac81bcc78bc4a74dc7e4e473c5833d2aad0103df
Cr-Commit-Position: refs/heads/master@{#324836}

Powered by Google App Engine
This is Rietveld 408576698