Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1071573003: [Android] Move testing/android/ to testing/android/native_test/ (Closed)

Created:
5 years, 8 months ago by jbudorick
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, jam, rickyz+watch_chromium.org, jbudorick+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, jln+watch_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, erikwright+watch_chromium.org, klundberg+watch_chromium.org, jochen+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Move testing/android/ to testing/android/native_test/ This will let us put android test code unrelated to native test APK wrapping elsewhere in testing/android/*. BUG= Committed: https://crrev.com/6ab22495db53ab1a423e90f9f698c36a92f9eb62 Cr-Commit-Position: refs/heads/master@{#324512}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : removing errant commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -754 lines) Patch
M base/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M build/apk_test.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/browsertests_apk/content_browser_tests_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D testing/android/BUILD.gn View 1 chunk +0 lines, -43 lines 0 comments Download
D testing/android/README.chromium View 1 chunk +0 lines, -2 lines 0 comments Download
D testing/android/java/AndroidManifest.xml View 1 chunk +0 lines, -38 lines 0 comments Download
D testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java View 1 chunk +0 lines, -124 lines 0 comments Download
D testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java View 1 chunk +0 lines, -230 lines 0 comments Download
M testing/android/native_test.gyp View 3 chunks +6 lines, -6 lines 0 comments Download
A + testing/android/native_test/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing/android/native_test/README.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing/android/native_test/java/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing/android/native_test/java/src/org/chromium/native_test/ChromeNativeTestActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing/android/native_test/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing/android/native_test/native_test_jni_onload.cc View 1 chunk +1 line, -1 line 0 comments Download
A + testing/android/native_test/native_test_launcher.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing/android/native_test/native_test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
A + testing/android/native_test/native_test_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + testing/android/native_test/native_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D testing/android/native_test_jni_onload.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D testing/android/native_test_launcher.h View 1 chunk +0 lines, -13 lines 0 comments Download
D testing/android/native_test_launcher.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D testing/android/native_test_util.h View 1 chunk +0 lines, -39 lines 0 comments Download
D testing/android/native_test_util.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M testing/test.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (7 generated)
jbudorick
split from https://codereview.chromium.org/1034053002/
5 years, 8 months ago (2015-04-08 15:56:49 UTC) #2
jbudorick
https://codereview.chromium.org/1071573003/diff/1/testing/android/native_test.gyp File testing/android/native_test.gyp (right): https://codereview.chromium.org/1071573003/diff/1/testing/android/native_test.gyp#newcode1 testing/android/native_test.gyp:1: # Copyright (c) 2012 The Chromium Authors. All rights ...
5 years, 8 months ago (2015-04-08 16:01:02 UTC) #3
Yaron
On 2015/04/08 16:01:02, jbudorick wrote: > https://codereview.chromium.org/1071573003/diff/1/testing/android/native_test.gyp > File testing/android/native_test.gyp (right): > > https://codereview.chromium.org/1071573003/diff/1/testing/android/native_test.gyp#newcode1 > ...
5 years, 8 months ago (2015-04-08 16:29:56 UTC) #4
Ted C
lgtm
5 years, 8 months ago (2015-04-08 17:24:30 UTC) #5
jbudorick
+dpranke for remaining OWNERS
5 years, 8 months ago (2015-04-08 17:27:44 UTC) #7
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-08 18:46:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071573003/40001
5 years, 8 months ago (2015-04-08 19:00:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54890)
5 years, 8 months ago (2015-04-08 23:15:35 UTC) #12
jbudorick
Guess I misunderstood the per-file BUILD.gn in src/OWNERS. Adding OWNERS for BUILD.gn files: +thakis for ...
5 years, 8 months ago (2015-04-09 04:35:56 UTC) #14
Nico
base, build, chrome lgtm Please say in the CL description why this is done. Cl ...
5 years, 8 months ago (2015-04-09 05:09:00 UTC) #15
jbudorick
On 2015/04/09 05:09:00, Nico wrote: > base, build, chrome lgtm > > Please say in ...
5 years, 8 months ago (2015-04-09 13:18:15 UTC) #16
xhwang
media/ lgtm
5 years, 8 months ago (2015-04-09 16:34:50 UTC) #17
no sievers
On 2015/04/09 04:35:56, jbudorick wrote: > +sievers for content/test/ and gpu/ lgtm
5 years, 8 months ago (2015-04-09 17:55:13 UTC) #18
jln (very slow on Chromium)
sandbox/ lgtm
5 years, 8 months ago (2015-04-09 18:47:54 UTC) #19
Lambros
remoting/ lgtm
5 years, 8 months ago (2015-04-09 19:12:02 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071573003/40001
5 years, 8 months ago (2015-04-09 19:40:38 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-09 21:52:10 UTC) #24
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 21:53:16 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6ab22495db53ab1a423e90f9f698c36a92f9eb62
Cr-Commit-Position: refs/heads/master@{#324512}

Powered by Google App Engine
This is Rietveld 408576698