Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1079943006: Make SSLClientSessionCacheOpenSSL thread-safe. (Closed)

Created:
5 years, 8 months ago by davidben
Modified:
5 years, 8 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SSLClientSessionCacheOpenSSL thread-safe. Although the network stack is single-threaded, it *should* be legal to spin up a parallel instance of everything on another thread. Until https://crbug.com/458365 is resolved, the session cache is one of the few global mutable objects in the network stack, apart from test code. Thus it needs to be locked. BUG=476713 Committed: https://crrev.com/84ce239582c58560bb11c731e17be5aeb45da863 Cr-Commit-Position: refs/heads/master@{#325459}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M net/ssl/ssl_client_session_cache_openssl.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/ssl/ssl_client_session_cache_openssl.cc View 1 5 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
5 years, 8 months ago (2015-04-13 23:22:11 UTC) #2
Ryan Sleevi
LGTM. The NSS code is also locked, so this shouldn't cause any regressions compared to ...
5 years, 8 months ago (2015-04-16 01:50:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079943006/20001
5 years, 8 months ago (2015-04-16 15:29:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 17:15:46 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 17:16:49 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84ce239582c58560bb11c731e17be5aeb45da863
Cr-Commit-Position: refs/heads/master@{#325459}

Powered by Google App Engine
This is Rietveld 408576698