Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: net/ssl/ssl_client_session_cache_openssl.h

Issue 1079943006: Make SSLClientSessionCacheOpenSSL thread-safe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/ssl/ssl_client_session_cache_openssl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/ssl_client_session_cache_openssl.h
diff --git a/net/ssl/ssl_client_session_cache_openssl.h b/net/ssl/ssl_client_session_cache_openssl.h
index bfe912b983a334ecc29bc1152d982541e1bcc9d6..9d2f4b57b9bb8d9d334d294bf433aa1859a37335 100644
--- a/net/ssl/ssl_client_session_cache_openssl.h
+++ b/net/ssl/ssl_client_session_cache_openssl.h
@@ -12,6 +12,7 @@
#include "base/containers/mru_cache.h"
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
+#include "base/synchronization/lock.h"
#include "base/threading/thread_checker.h"
#include "base/time/time.h"
#include "net/base/net_export.h"
@@ -82,7 +83,10 @@ class NET_EXPORT SSLClientSessionCacheOpenSSL {
CacheEntryMap cache_;
size_t lookups_since_flush_;
- base::ThreadChecker thread_checker_;
+ // TODO(davidben): After https://crbug.com/458365 is fixed, replace this with
+ // a ThreadChecker. The session cache should be single-threaded like other
+ // classes in net.
+ base::Lock lock_;
DISALLOW_COPY_AND_ASSIGN(SSLClientSessionCacheOpenSSL);
};
« no previous file with comments | « no previous file | net/ssl/ssl_client_session_cache_openssl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698