Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1079943002: Avoid copying the data string when posting ImportantFileWriter write tasks (Closed)

Created:
5 years, 8 months ago by hashimoto
Modified:
5 years, 8 months ago
Reviewers:
Nico, sky
CC:
chromium-reviews, tfarina, erikwright+watch_chromium.org, noyau+watch_chromium.org, gab
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid copying the data string when posting ImportantFileWriter write tasks When binding the data string to a callback, the existing code copies the data which can be 1MB+ sometimes. Use scoped_ptr to avoid unnecessary data copy. BUG=None Committed: https://crrev.com/1ad9bfe4e302fd57bbffd45ec9ad248893a7b2ba Cr-Commit-Position: refs/heads/master@{#327234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M base/files/important_file_writer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/files/important_file_writer.cc View 6 chunks +17 lines, -13 lines 0 comments Download
M base/files/important_file_writer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/bookmarks/browser/bookmark_storage.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hashimoto
5 years, 8 months ago (2015-04-27 05:00:39 UTC) #2
Nico
lgtm (I was a bit skeptical about this, but since there seem to be very ...
5 years, 8 months ago (2015-04-27 17:53:59 UTC) #3
hashimoto
TBRing sky@ as an owner of components/bookmarks.
5 years, 8 months ago (2015-04-28 03:49:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079943002/1
5 years, 8 months ago (2015-04-28 03:49:54 UTC) #7
sky
LGTM
5 years, 8 months ago (2015-04-28 04:23:47 UTC) #8
hashimoto
On 2015/04/28 04:23:47, sky wrote: > LGTM Thanks, removing the TBR line from the change ...
5 years, 8 months ago (2015-04-28 04:29:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-28 05:27:27 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 05:28:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ad9bfe4e302fd57bbffd45ec9ad248893a7b2ba
Cr-Commit-Position: refs/heads/master@{#327234}

Powered by Google App Engine
This is Rietveld 408576698