Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: components/bookmarks/browser/bookmark_storage.cc

Issue 1079943002: Avoid copying the data string when posting ImportantFileWriter write tasks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/files/important_file_writer_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/bookmarks/browser/bookmark_storage.h" 5 #include "components/bookmarks/browser/bookmark_storage.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/json/json_file_value_serializer.h" 10 #include "base/json/json_file_value_serializer.h"
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 } 198 }
199 199
200 bool BookmarkStorage::SaveNow() { 200 bool BookmarkStorage::SaveNow() {
201 if (!model_ || !model_->loaded()) { 201 if (!model_ || !model_->loaded()) {
202 // We should only get here if we have a valid model and it's finished 202 // We should only get here if we have a valid model and it's finished
203 // loading. 203 // loading.
204 NOTREACHED(); 204 NOTREACHED();
205 return false; 205 return false;
206 } 206 }
207 207
208 std::string data; 208 scoped_ptr<std::string> data(new std::string);
209 if (!SerializeData(&data)) 209 if (!SerializeData(data.get()))
210 return false; 210 return false;
211 writer_.WriteNow(data); 211 writer_.WriteNow(data.Pass());
212 return true; 212 return true;
213 } 213 }
214 214
215 } // namespace bookmarks 215 } // namespace bookmarks
OLDNEW
« no previous file with comments | « base/files/important_file_writer_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698