ServiceWorker: Stop exposing ServiceWorkerContextCore

ServiceWorker: Stop exposing ServiceWorkerContextCore

External components (eg. Push) can directly access SWContextCore, but the
context core is designed for internal use and should be accessed via
SWContextWrapper because it can be null in some cases (eg, failing to
restart the system. See [1,2] for details of the wrapper-core layering).

To enforce the rule, this CL stops exposing the context core and makes the
wrapper to provide interfaces for that instead.

[1] https://code.google.com/p/chromium/issues/detail?id=371675#c18
[2] https://docs.google.com/document/d/1eXdgnAOZC4dDDybmRpXT0t0lOYGhFf7xajOSanEb91Y/edit?usp=sharing

BUG=472019
TEST=compile

Committed: https://crrev.com/d389a96ff7963b90a7a80bc3cd3318fdf48c0e70
Cr-Commit-Position: refs/heads/master@{#326464}

[nhiroki, 2015-04-15 06:32:48]

Patchset #1 (id:1) has been deleted

[nhiroki, 2015-04-15 06:32:56]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2015-04-15 06:33:02]

Patchset #1 (id:40001) has been deleted

[nhiroki, 2015-04-15 06:33:08]

Patchset #1 (id:60001) has been deleted

[nhiroki, 2015-04-15 07:10:14]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org

[nhiroki, 2015-04-15 07:10:42]

PTAL

[falken, 2015-04-15 08:03:20]

lgtm, looks like a good idea to made the system more encapsulated.

https://codereview.chromium.org/1079923002/diff/80001/content/browser/service...
File content/browser/service_worker/service_worker_context_watcher.cc (right):

https://codereview.chromium.org/1079923002/diff/80001/content/browser/service...
content/browser/service_worker/service_worker_context_watcher.cc:72: }
nit: braces not needed

[Peter Beverloo, 2015-04-15 12:21:38]

push and notifications LGTM.

[nhiroki, 2015-04-15 23:38:16]

Thank you!

https://codereview.chromium.org/1079923002/diff/80001/content/browser/service...
File content/browser/service_worker/service_worker_context_watcher.cc (right):

https://codereview.chromium.org/1079923002/diff/80001/content/browser/service...
content/browser/service_worker/service_worker_context_watcher.cc:72: }
On 2015/04/15 08:03:20, falken wrote:
> nit: braces not needed

Done.

[nhiroki, 2015-04-15 23:46:11]

nhiroki@chromium.org changed reviewers:
+ jkarlin@chromium.org, jochen@chromium.org, mek@chromium.org,
peter@chromium.org, pfeldman@chromium.org

[nhiroki, 2015-04-15 23:46:12]

Added owners:

jkarlin@ for c/b/background_sync/
pfeldman@ for c/b/devtools/
mek@ for c/b/{geofencing,navigator_connect}
jochen@ for content/public/

PTAL, thanks.

[Marijn Kruisselbrink, 2015-04-15 23:53:35]

> mek@ for c/b/{geofencing,navigator_connect}
lgtm

[Marijn Kruisselbrink, 2015-04-15 23:57:02]

https://codereview.chromium.org/1079923002/diff/120001/content/browser/servic...
File content/browser/service_worker/service_worker_context_wrapper.h (right):

https://codereview.chromium.org/1079923002/diff/120001/content/browser/servic...
content/browser/service_worker/service_worker_context_wrapper.h:103: const
FindRegistrationCallback& callback);
If you're trying to mirror ServiceWorkerStorage methods,
FindRegistrationForIdOnly is missing here it seems.

[jkarlin, 2015-04-16 11:20:53]

background_sync/ lgtm

[jochen (gone - plz use gerrit), 2015-04-17 09:29:50]

lgtm

[nhiroki, 2015-04-23 05:01:04]

Thank you for reviewing.

https://codereview.chromium.org/1079923002/diff/120001/content/browser/servic...
File content/browser/service_worker/service_worker_context_wrapper.h (right):

https://codereview.chromium.org/1079923002/diff/120001/content/browser/servic...
content/browser/service_worker/service_worker_context_wrapper.h:103: const
FindRegistrationCallback& callback);
On 2015/04/15 23:57:01, Marijn Kruisselbrink wrote:
> If you're trying to mirror ServiceWorkerStorage methods,
> FindRegistrationForIdOnly is missing here it seems.

Thank you for pointing it out. Currently there is no user of the function, so
I'd prefer to add it lazily according to the YAGNI principle :)

[nhiroki, 2015-04-23 05:01:10]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2015-04-23 05:01:11]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org,
peter@chromium.org, jochen@chromium.org, jkarlin@chromium.org, mek@chromium.org
Link to the patchset: https://codereview.chromium.org/1079923002/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2015-04-23 05:01:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079923002/140001

[commit-bot: I haz the power, 2015-04-23 06:12:37]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2015-04-23 06:13:33]

Patchset 4 (id:??) landed as
https://crrev.com/d389a96ff7963b90a7a80bc3cd3318fdf48c0e70
Cr-Commit-Position: refs/heads/master@{#326464}