content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc - Issue 1079923002: ServiceWorker: Stop exposing ServiceWorkerContextCore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc

Issue 1079923002: ServiceWorker: Stop exposing ServiceWorkerContextCore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/geofencing/geofencing_manager.cc ('k') | content/browser/notifications/notification_event_dispatcher_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc

diff --git a/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc b/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc

index 7f7d350ddf4415bb284aba1d0471c0eee01c634e..17ee080c87fd09784cbfaa80fde0bbe1f11f3c43 100644

--- a/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc

+++ b/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc

@@ -83,7 +83,7 @@ void NavigatorConnectServiceWorkerService::SendMessage(

for (const auto& port : sent_message_ports)

MessagePortService::GetInstance()->HoldMessages(port.id);

- service_worker_context_->context()->storage()->FindRegistrationForId(

+ service_worker_context_->FindRegistrationForId(

service_worker_registration_id_, service_worker_registration_origin_,

base::Bind(&NavigatorConnectServiceWorkerService::DeliverMessage,

weak_factory_.GetWeakPtr(), message.message_as_string,

@@ -143,7 +143,7 @@ void NavigatorConnectServiceWorkerServiceFactory::Connect(

DCHECK_CURRENTLY_ON(BrowserThread::IO);

// Find the right service worker to service this connection.

- service_worker_context_->context()->storage()->FindRegistrationForDocument(

+ service_worker_context_->FindRegistrationForDocument(

client.target_url,

base::Bind(&NavigatorConnectServiceWorkerServiceFactory::

GotServiceWorkerRegistration,