Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1079913002: [Win] Keep client area the same size as window when fullscreened. (Closed)

Created:
5 years, 8 months ago by jackhou1
Modified:
5 years, 8 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Win] Keep client area the same size as window when fullscreened. At the moment we add an inset on the bottom and right borders of the client area because Windows doesn't render the non-client area properly otherwise (crbug.com/376608). This is not needed during fullscreen, and causes those edges to be non-hittable (see bug below). This CL makes the inset zero during fullscreen. BUG=406612 Committed: https://crrev.com/ff7f5276bf1dc8eda41af0d976ce5fba85a50f63 Cr-Commit-Position: refs/heads/master@{#325199}

Patch Set 1 #

Patch Set 2 : Add test. #

Total comments: 2

Patch Set 3 : Use DesktopWindowTreeHost::IsFullscreen #

Total comments: 2

Patch Set 4 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M chrome/browser/apps/app_window_interactive_uitest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/glass_app_window_frame_view_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/window_api_interactive/test.js View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
jackhou1
benwells, could you take a look?
5 years, 8 months ago (2015-04-14 00:27:47 UTC) #2
tapted
https://codereview.chromium.org/1079913002/diff/20001/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc File chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc (right): https://codereview.chromium.org/1079913002/diff/20001/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc#newcode33 chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc:33: static_cast<ui::BaseWindow*>(app_window_)->IsFullscreen()) { is this the same as the IsFullscreen() ...
5 years, 8 months ago (2015-04-14 04:34:56 UTC) #3
jackhou1
https://codereview.chromium.org/1079913002/diff/20001/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc File chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc (right): https://codereview.chromium.org/1079913002/diff/20001/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc#newcode33 chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc:33: static_cast<ui::BaseWindow*>(app_window_)->IsFullscreen()) { On 2015/04/14 04:34:56, tapted wrote: > is ...
5 years, 8 months ago (2015-04-14 07:12:51 UTC) #4
benwells
lgtm. Thanks Jack! https://codereview.chromium.org/1079913002/diff/40001/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc File chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc (right): https://codereview.chromium.org/1079913002/diff/40001/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc#newcode30 chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc:30: // Use the default client insets ...
5 years, 8 months ago (2015-04-14 22:55:18 UTC) #5
jackhou1
https://codereview.chromium.org/1079913002/diff/40001/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc File chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc (right): https://codereview.chromium.org/1079913002/diff/40001/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc#newcode30 chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc:30: // Use the default client insets for an opaque ...
5 years, 8 months ago (2015-04-14 23:34:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079913002/60001
5 years, 8 months ago (2015-04-14 23:35:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/61517)
5 years, 8 months ago (2015-04-14 23:56:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079913002/60001
5 years, 8 months ago (2015-04-15 06:37:30 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-15 06:46:57 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 06:47:48 UTC) #15
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ff7f5276bf1dc8eda41af0d976ce5fba85a50f63
Cr-Commit-Position: refs/heads/master@{#325199}

Powered by Google App Engine
This is Rietveld 408576698