chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc - Issue 1079913002: [Win] Keep client area the same size as window when fullscreened.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc

Issue 1079913002: [Win] Keep client area the same size as window when fullscreened. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_window_interactive_uitest.cc ('k') | chrome/browser/ui/views/apps/glass_app_window_frame_view_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc

diff --git a/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc b/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc

index 01ee9fc4892cce1ffd8c167f0a27ab891a23ee75..0fa0946bb5703152be2d7403471e8402a2a61796 100644

--- a/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc

+++ b/chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc

@@ -27,10 +27,12 @@ AppWindowDesktopWindowTreeHostWin::~AppWindowDesktopWindowTreeHostWin() {

bool AppWindowDesktopWindowTreeHostWin::GetClientAreaInsets(

gfx::Insets* insets) const {

- // Use the default client insets for an opaque frame or a glass popup/app

- // frame.

- if (!app_window_->glass_frame_view())

+ // The inset added below is only necessary for the native glass frame, i.e.

+ // not for colored frames drawn by Chrome, or when DWM is disabled.

+ // In fullscreen the frame is not visible.

+ if (!app_window_->glass_frame_view() || IsFullscreen()) {

return false;

+ }

// This tells Windows that most of the window is a client area, meaning Chrome

// will draw it. Windows still fills in the glass bits because of the