Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1079843002: DevTools: allow storing devtools preferences on the browser side. (Closed)

Created:
5 years, 8 months ago by pfeldman
Modified:
5 years, 8 months ago
Reviewers:
Tom Sepez, dgozman
CC:
chromium-reviews, aandrey+blink_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: allow storing devtools preferences on the browser side. BUG=376788 Committed: https://crrev.com/6672e7d32a24d2f35d6decd9f3cd2a8285c16f6c Cr-Commit-Position: refs/heads/master@{#325019}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : w/ shell #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : restored settings param #

Total comments: 2

Patch Set 6 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -15 lines) Patch
M chrome/browser/devtools/devtools_embedder_message_dispatcher.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 2 3 5 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_interfaces.cc View 1 2 3 4 5 2 chunks +7 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
pfeldman
5 years, 8 months ago (2015-04-12 19:46:48 UTC) #2
pfeldman
PTAL
5 years, 8 months ago (2015-04-13 13:12:34 UTC) #4
dgozman
lgtm https://codereview.chromium.org/1079843002/diff/80001/chrome/browser/devtools/devtools_ui_bindings.cc File chrome/browser/devtools/devtools_ui_bindings.cc (right): https://codereview.chromium.org/1079843002/diff/80001/chrome/browser/devtools/devtools_ui_bindings.cc#newcode211 chrome/browser/devtools/devtools_ui_bindings.cc:211: using DispatchCallback = This one is not used. ...
5 years, 8 months ago (2015-04-13 13:37:48 UTC) #5
pfeldman
https://codereview.chromium.org/1079843002/diff/80001/content/shell/renderer/test_runner/test_interfaces.cc File content/shell/renderer/test_runner/test_interfaces.cc (right): https://codereview.chromium.org/1079843002/diff/80001/content/shell/renderer/test_runner/test_interfaces.cc#newcode122 content/shell/renderer/test_runner/test_interfaces.cc:122: test_runner_->ShowDevTools(spec.c_str(), std::string()); On 2015/04/13 13:37:48, dgozman wrote: > Either ...
5 years, 8 months ago (2015-04-13 16:08:10 UTC) #6
pfeldman
@tsepez: we migrated devtools settings from being stored in localStorage to the browser-side profile storage.
5 years, 8 months ago (2015-04-13 16:08:50 UTC) #8
Tom Sepez
lgtm https://codereview.chromium.org/1079843002/diff/100001/content/shell/renderer/test_runner/test_interfaces.cc File content/shell/renderer/test_runner/test_interfaces.cc (right): https://codereview.chromium.org/1079843002/diff/100001/content/shell/renderer/test_runner/test_interfaces.cc#newcode122 content/shell/renderer/test_runner/test_interfaces.cc:122: std::string settings = base::StringPrintf( Even thought this is ...
5 years, 8 months ago (2015-04-13 16:15:48 UTC) #9
pfeldman
https://codereview.chromium.org/1079843002/diff/100001/content/shell/renderer/test_runner/test_interfaces.cc File content/shell/renderer/test_runner/test_interfaces.cc (right): https://codereview.chromium.org/1079843002/diff/100001/content/shell/renderer/test_runner/test_interfaces.cc#newcode122 content/shell/renderer/test_runner/test_interfaces.cc:122: std::string settings = base::StringPrintf( On 2015/04/13 16:15:48, Tom Sepez ...
5 years, 8 months ago (2015-04-14 09:06:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079843002/120001
5 years, 8 months ago (2015-04-14 09:06:59 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 8 months ago (2015-04-14 10:09:19 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 10:10:09 UTC) #15
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/6672e7d32a24d2f35d6decd9f3cd2a8285c16f6c
Cr-Commit-Position: refs/heads/master@{#325019}

Powered by Google App Engine
This is Rietveld 408576698