DevTools: allow storing devtools preferences on the browser side.

content/shell/renderer/test_runner/test_interfaces.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/test_runner/test_interfaces.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 100 matching lines @@
     test_runner_->setShouldDumpFrameLoadCallbacks(true);
   if (spec.find("/dumpAsText/") != std::string::npos) {
     test_runner_->setShouldDumpAsText(true);
     test_runner_->setShouldGeneratePixelResults(false);
   }
   if (spec.find("/inspector/") != std::string::npos ||
       spec.find("/inspector-enabled/") != std::string::npos)
     test_runner_->ClearDevToolsLocalStorage();
   if (spec.find("/inspector/") != std::string::npos) {
     // Subfolder name determines default panel to open.
-    std::string settings = "";
     std::string test_path = spec.substr(spec.find("/inspector/") + 11);
-    size_t slash_index = test_path.find("/");
-    std::string test_path_setting = base::StringPrintf(
-        "\"testPath\":\"\\\"%s\\\"\"", spec.c_str());
-
-    // TODO(pfeldman): remove once migrated to testPath.
-    std::string last_active_panel;
-    if (slash_index != std::string::npos) {
-      last_active_panel = base::StringPrintf(
-          ",\"lastActivePanel\":\"\\\"%s\\\"\"",
-          test_path.substr(0, slash_index).c_str());
-    }
-
-    test_runner_->ShowDevTools(base::StringPrintf("{%s%s}",
-        test_path_setting.c_str(), last_active_panel.c_str()), std::string());
+    std::string settings = base::StringPrintf(

[Tom Sepez, 2015/04/13 16:15:48]

Even thought this is only for testing, and even though its been like this
forever, you might want to be careful if spec contains punctuation like " or \.

[pfeldman, 2015/04/14 09:06:33]

Done.

+        "{\"testPath\":\"\\\"%s\\\"\"}", spec.c_str());
+    test_runner_->ShowDevTools(settings, std::string());
   }
   if (spec.find("/viewsource/") != std::string::npos) {
     test_runner_->setShouldEnableViewSource(true);
     test_runner_->setShouldGeneratePixelResults(false);
     test_runner_->setShouldDumpAsMarkup(true);
   }
 }
 
 void TestInterfaces::WindowOpened(WebTestProxyBase* proxy) {
   window_list_.push_back(proxy);
@@ skipping 35 matching lines @@
 
 blink::WebThemeEngine* TestInterfaces::GetThemeEngine() {
   if (!test_runner_->UseMockTheme())
     return 0;
   if (!theme_engine_.get())
     theme_engine_.reset(new MockWebThemeEngine());
   return theme_engine_.get();
 }
 
 }  // namespace content