Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 10796069: Split VFP support in VFP2/3 (Closed)

Created:
8 years, 5 months ago by lmcloughlin
Modified:
8 years, 5 months ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Visibility:
Public.

Description

Split VFP support in VFP2/3 BUG=none TEST=Build with v8_can_use_vfp2_instructions=true on hardware with VFP2 but without VFP3, verify no crash

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -17 lines) Patch
M build/common.gypi View 2 chunks +9 lines, -3 lines 0 comments Download
M src/arm/assembler-arm.cc View 4 chunks +9 lines, -6 lines 4 comments Download
M src/arm/code-stubs-arm.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/v8globals.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
lmcloughlin
Uploading this since it's used for Raspberry Pi builds of Chromium to use VFP2 capability ...
8 years, 5 months ago (2012-07-20 21:03:12 UTC) #1
Yang
Some comments. Adding Sven for more opinions. Generally, this patch opens up a bunch of ...
8 years, 5 months ago (2012-07-23 07:21:19 UTC) #2
Yang
8 years, 5 months ago (2012-07-24 13:53:21 UTC) #3
This CL is superseded by http://codereview.chromium.org/10818026/

Powered by Google App Engine
This is Rietveld 408576698