src/objects.h - Issue 107933005: Templatise type representation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 107933005: Templatise type representation (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index f09d58fc5dc53dc5a3b99abb8fd76e944373f8a9..da580aa1e926ee10d00e9de7c4b1d8188d4c71ea 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -880,7 +880,11 @@ class Failure;

class FixedArrayBase;

class ObjectVisitor;

class StringStream;

-class Type;

+// Work around the fact that we cannot just say "class Type;" anymore, because

+// C++ is a pile of garbage with no proper compositionality or abstraction.

titzer 2013/12/17 09:13:07 Agree with the sentiment--and glad to have a comme

rossberg 2013/12/17 09:33:13 Had to vent. I literally wasted a day trying to fi

+template<class> class TypeImpl;

+class HeapTypeConfig;

+typedef TypeImpl<HeapTypeConfig> Type;

// A template-ized version of the IsXXX functions.