Templatise type representation

src/objects.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 862 matching lines @@
 class AccessorPair;
 class AllocationSite;
 class AllocationSiteCreationContext;
 class AllocationSiteUsageContext;
 class DictionaryElementsAccessor;
 class ElementsAccessor;
 class Failure;
 class FixedArrayBase;
 class ObjectVisitor;
 class StringStream;
-class Type;
+// Work around the fact that we cannot just say "class Type;" anymore, because
+// C++ is a pile of garbage with no proper compositionality or abstraction.

[titzer, 2013/12/17 09:13:07]

Agree with the sentiment--and glad to have a comment explaining why-- but
vitriol should be limited to code review comments, you ____-_______ing ____er :)

[rossberg, 2013/12/17 09:33:13]

Had to vent. I literally wasted a day trying to find a way that avoids this
abstraction leak all over the place. AFAICT, there is none.

Removed the latter half of the comment.

+template<class> class TypeImpl;
+class HeapTypeConfig;
+typedef TypeImpl<HeapTypeConfig> Type;
 
 
 // A template-ized version of the IsXXX functions.
 template <class C> inline bool Is(Object* obj);
 
 #ifdef VERIFY_HEAP
 #define DECLARE_VERIFIER(Name) void Name##Verify();
 #else
 #define DECLARE_VERIFIER(Name)
 #endif
@@ skipping 9712 matching lines @@
     } else {
       value &= ~(1 << bit_position);
     }
     return value;
   }
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_H_