Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: third_party/WebKit/Source/core/html/track/TextTrack.cpp

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Blink repo changes and addressed comments from philipj and UX Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/TextTrack.cpp
diff --git a/third_party/WebKit/Source/core/html/track/TextTrack.cpp b/third_party/WebKit/Source/core/html/track/TextTrack.cpp
index 1cd60174bdb63963e3b387e178c1848c9b1bfd7f..d97bbc9eb8df4827568bf714d4e841b298140090 100644
--- a/third_party/WebKit/Source/core/html/track/TextTrack.cpp
+++ b/third_party/WebKit/Source/core/html/track/TextTrack.cpp
@@ -443,6 +443,14 @@ int TextTrack::trackIndexRelativeToRenderedTracks()
return m_renderedTrackIndex;
}
+bool TextTrack::isRenderable()
fs 2016/02/23 13:16:44 Maybe move this closer to isRendered() and format
srivats 2016/02/24 05:20:18 Done.
+{
+ // A track can be displayed when it's of kind captions or subtitles and hasn't failed to load
fs 2016/02/23 13:16:44 uNit: Add full stop.
srivats 2016/02/24 05:20:18 Done.
+ if ((kind() == captionsKeyword() || kind() == subtitlesKeyword()) && readinessState() != FailedToLoad)
+ return true;
+ return false;
+}
+
const AtomicString& TextTrack::interfaceName() const
{
return EventTargetNames::TextTrack;

Powered by Google App Engine
This is Rietveld 408576698