Support text track selection in video controls

third_party/WebKit/Source/core/html/track/TextTrack.cpp

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2011, 2012, 2013 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 425 matching lines @@
 int TextTrack::trackIndexRelativeToRenderedTracks()
 {
     ASSERT(m_trackList);
 
     if (m_renderedTrackIndex == invalidTrackIndex)
         m_renderedTrackIndex = m_trackList->getTrackIndexRelativeToRenderedTracks(this);
 
     return m_renderedTrackIndex;
 }
 
+bool TextTrack::isRenderable()

[fs, 2016/02/23 13:16:44]

Maybe move this closer to isRendered() and format it similarly so that it
becomes easy to see what they have in common and how they differ? Maybe it
should be "canBeRendered()" to avoid it looking to similar to isRendered() (and
to provide some form of relation between them)?

[srivats, 2016/02/24 05:20:18]

Done.

+{
+    // A track can be displayed when it's of kind captions or subtitles and hasn't failed to load

[fs, 2016/02/23 13:16:44]

uNit: Add full stop.

[srivats, 2016/02/24 05:20:18]

Done.

+    if ((kind() == captionsKeyword() || kind() == subtitlesKeyword()) && readinessState() != FailedToLoad)
+        return true;
+    return false;
+}
+
 const AtomicString& TextTrack::interfaceName() const
 {
     return EventTargetNames::TextTrack;
 }
 
 ExecutionContext* TextTrack::executionContext() const
 {
     HTMLMediaElement* owner = mediaElement();
     return owner ? owner->executionContext() : 0;
 }
@@ skipping 17 matching lines @@
 {
     visitor->trace(m_cues);
     visitor->trace(m_activeCues);
     visitor->trace(m_regions);
     visitor->trace(m_trackList);
     TrackBase::trace(visitor);
     RefCountedGarbageCollectedEventTargetWithInlineData<TextTrack>::trace(visitor);
 }
 
 } // namespace blink