Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1079163007: net_log_logger_ replaced with write_to_file_observer_ (Closed)

Created:
5 years, 8 months ago by vishal.b
Modified:
5 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, jam, eroman, darin-cc_chromium.org, mmenke, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net_log_logger_ replaced with write_to_file_observer_ considering https://codereview.chromium.org/1084533002 refactor BUG=473252 TBR=jam Committed: https://crrev.com/94fed10d9232ff086aa2431a8ef4522a0728aa08 Cr-Commit-Position: refs/heads/master@{#326499}

Patch Set 1 #

Patch Set 2 : net_log_logger_ replaced with write_to_file_observer_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -41 lines) Patch
M chrome/browser/net/chrome_net_log.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_net_log.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/net/net_log_temp_file.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/net/net_log_temp_file.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M components/cronet/android/url_request_context_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/url_request_context_adapter.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M content/shell/browser/shell_net_log.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_net_log.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
vishal.b
net_log_logger_ replaced with write_to_file_observer_ considering https://codereview.chromium.org/1084533002 refactor
5 years, 8 months ago (2015-04-22 08:59:12 UTC) #2
eroman
LGTM. Can you change the description to something more like: Rename net_log_logger_ to write_to_file_observer_. BUG=473252
5 years, 8 months ago (2015-04-22 15:38:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079163007/1
5 years, 8 months ago (2015-04-23 05:29:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/17681) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-23 05:34:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079163007/1
5 years, 8 months ago (2015-04-23 05:52:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/17690) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-23 05:56:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079163007/20001
5 years, 8 months ago (2015-04-23 12:13:41 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 13:10:50 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 13:11:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94fed10d9232ff086aa2431a8ef4522a0728aa08
Cr-Commit-Position: refs/heads/master@{#326499}

Powered by Google App Engine
This is Rietveld 408576698