Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1079013002: Add "emulate push event" button to ServiceWorkersView in DevTools [2/2 blink] (Closed)

Created:
5 years, 8 months ago by horo
Modified:
5 years, 8 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add "emulate push event" button to ServiceWorkersView in DevTools [2/2 blink] 1/2 chromium: https://codereview.chromium.org/1064523003/ 2/2 blink: This cl. Screenshot: https://code.google.com/p/chromium/issues/detail?id=474459#c4 BUG=474459 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193583

Patch Set 1 : #

Total comments: 2

Patch Set 2 : s/dispatchPushEvent/deliverPushMessage/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -17 lines) Patch
M Source/devtools/devtools.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A Source/devtools/front_end/Images/notifications.svg View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/resources/ServiceWorkersView.js View 1 5 chunks +18 lines, -2 lines 0 comments Download
M Source/devtools/front_end/resources/serviceWorkersView.css View 2 chunks +23 lines, -15 lines 0 comments Download
M Source/devtools/front_end/sdk/ServiceWorkerManager.js View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
horo
pfeldman@ Could you please review this?
5 years, 8 months ago (2015-04-10 08:16:19 UTC) #4
pfeldman
https://codereview.chromium.org/1079013002/diff/40001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/1079013002/diff/40001/Source/devtools/protocol.json#newcode4156 Source/devtools/protocol.json:4156: "name": "dispatchPushEvent", emitPushEvent?
5 years, 8 months ago (2015-04-10 11:54:39 UTC) #5
pfeldman
lgtm
5 years, 8 months ago (2015-04-10 12:37:55 UTC) #6
horo
https://codereview.chromium.org/1079013002/diff/40001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/1079013002/diff/40001/Source/devtools/protocol.json#newcode4156 Source/devtools/protocol.json:4156: "name": "dispatchPushEvent", On 2015/04/10 11:54:38, pfeldman wrote: > emitPushEvent? ...
5 years, 8 months ago (2015-04-10 23:18:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079013002/60001
5 years, 8 months ago (2015-04-10 23:19:18 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-11 01:06:02 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193583

Powered by Google App Engine
This is Rietveld 408576698