Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1079003002: bindings: v8::Handle -> v8::Local in Source/Modules (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 8 months ago
Reviewers:
haraken, Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bindings: v8::Handle -> v8::Local in Source/Modules Replacing bunch of v8::Handle with v8::Local in files in in Source/Modules BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193553

Patch Set 1 #

Patch Set 2 : fixed build errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/modules/cachestorage/CacheTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/crypto/CryptoResultImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/fetch/RequestInit.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/navigatorconnect/AcceptConnectionObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 8 months ago (2015-04-10 09:02:49 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-10 09:10:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079003002/20001
5 years, 8 months ago (2015-04-10 09:38:35 UTC) #5
anujsharma
On 2015/04/10 09:10:10, haraken wrote: > LGTM Thanks haraken for lgtm.
5 years, 8 months ago (2015-04-10 09:43:39 UTC) #6
Mike West
haraken@ is _fast_. :) LGTM as well, since you asked.
5 years, 8 months ago (2015-04-10 11:21:16 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 15:26:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193553

Powered by Google App Engine
This is Rietveld 408576698