Source/modules/serviceworkers/RespondWithObserver.cpp - Issue 1079003002: bindings: v8::Handle -> v8::Local in Source/Modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 1079003002: bindings: v8::Handle -> v8::Local in Source/Modules (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fixed build errors Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/navigatorconnect/AcceptConnectionObserver.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/RespondWithObserver.cpp

diff --git a/Source/modules/serviceworkers/RespondWithObserver.cpp b/Source/modules/serviceworkers/RespondWithObserver.cpp

index 0b5cd349e03c0b7a077fc9d4afd084a18046ffd6..410d4ccaeed73d326f567c9ef6f1d5d6864972d9 100644

--- a/Source/modules/serviceworkers/RespondWithObserver.cpp

+++ b/Source/modules/serviceworkers/RespondWithObserver.cpp

@@ -91,7 +91,7 @@ public:

Rejected,

};

- static v8::Handle<v8::Function> createFunction(ScriptState* scriptState, RespondWithObserver* observer, ResolveType type)

+ static v8::Local<v8::Function> createFunction(ScriptState* scriptState, RespondWithObserver* observer, ResolveType type)

{

ThenFunction* self = new ThenFunction(scriptState, observer, type);

return self->bindToV8Function();