chrome/renderer/printing/print_web_view_helper.cc - Issue 107893003: Make the renderer-side prerendering code use RenderFrames instead of RenderViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/print_web_view_helper.cc

Issue 107893003: Make the renderer-side prerendering code use RenderFrames instead of RenderViews. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: creis review comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/prerender/prerender_helper.cc ('K') | « chrome/renderer/prerender/prerender_media_load_deferrer.cc ('k') | content/browser/frame_host/frame_tree.h » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/printing/print_web_view_helper.cc

===================================================================

--- chrome/renderer/printing/print_web_view_helper.cc (revision 239602)

+++ chrome/renderer/printing/print_web_view_helper.cc (working copy)

@@ -20,6 +20,7 @@

#include "chrome/common/print_messages.h"

#include "chrome/common/render_messages.h"

#include "chrome/renderer/prerender/prerender_helper.h"

+#include "content/public/renderer/render_frame.h"

#include "content/public/renderer/render_thread.h"

#include "content/public/renderer/render_view.h"

#include "content/public/renderer/web_preferences.h"

@@ -757,7 +758,8 @@

DCHECK(frame);

// Allow Prerendering to cancel this print request if necessary.

- if (prerender::PrerenderHelper::IsPrerendering(render_view())) {

+ if (prerender::PrerenderHelper::IsPrerendering(

+ render_view()->GetMainRenderFrame())) {

Send(new ChromeViewHostMsg_CancelPrerenderForPrinting(routing_id()));

return;

}