Make the renderer-side prerendering code use RenderFrames instead of RenderViews.

content/browser/web_contents/web_contents_impl.cc

Index: content/browser/web_contents/web_contents_impl.cc
===================================================================
--- content/browser/web_contents/web_contents_impl.cc	(revision 239602)
+++ content/browser/web_contents/web_contents_impl.cc	(working copy)
@@ -2768,6 +2768,20 @@
   return OnMessageReceived(NULL, render_frame_host, message);
 }
 
+void WebContentsImpl::RenderFrameCreated(RenderFrameHost* render_frame_host) {
+  // Note this is only for subframes, the notification for the main frame
+  // happens in RenderViewCreated.

[mmenke, 2013/12/10 20:56:41]

Shouldn't this comment be in the WebContentsObserver header?  Seems like that's
where most people who work on WebContentsObservers will look.

[jam, 2013/12/10 21:14:17]

I specifically avoided that because it's an implementation detail of content,
and may change in the future.

Embedders should only care/know that RenderFrameCreated is called for every
RenderFrame.

[mmenke, 2013/12/10 21:26:39]

Sorry, I completely misunderstood the comment (I was thinking it meant
RenderFrameCreated was only called for subframes, completely missing the other
call below).

+  FOR_EACH_OBSERVER(WebContentsObserver,
+                    observers_,
+                    RenderFrameCreated(render_frame_host));
+}
+
+void WebContentsImpl::RenderFrameDeleted(RenderFrameHost* render_frame_host) {
+  FOR_EACH_OBSERVER(WebContentsObserver,
+                    observers_,
+                    RenderFrameDeleted(render_frame_host));
+}
+
 RenderViewHostDelegateView* WebContentsImpl::GetDelegateView() {
   return render_view_host_delegate_view_;
 }
@@ -2828,6 +2842,13 @@
 
   FOR_EACH_OBSERVER(
       WebContentsObserver, observers_, RenderViewCreated(render_view_host));
+
+  // We tell the observers now instead of when the main RenderFrameHostImpl is
+  // constructed because otherwise it would be too early (i.e. IPCs sent to the
+  // frame would be dropped because it's not created yet).
+  RenderFrameHost* main_frame = GetMainFrame();
+  FOR_EACH_OBSERVER(
+      WebContentsObserver, observers_, RenderFrameCreated(main_frame));
 }
 
 void WebContentsImpl::RenderViewReady(RenderViewHost* rvh) {