[es6]: Lexical arguments for arrow functions

src/scopes.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_SCOPES_H_
 #define V8_SCOPES_H_
 
 #include "src/ast.h"
 #include "src/pending-compilation-error-handler.h"
 #include "src/zone.h"
@@ skipping 376 matching lines @@
     return rest_index_ >= 0;
   }
 
   bool is_simple_parameter_list() const {
     DCHECK(is_function_scope());
     if (rest_index_ >= 0) return false;
     return true;
   }
 
   // The local variable 'arguments' if we need to allocate it; NULL otherwise.
-  Variable* arguments() const { return arguments_; }
+  Variable* arguments() const {
+    return is_arrow_scope() ? nullptr : arguments_;

[adamk, 2015/04/09 15:56:03]

Why is this necessary? Reading the code again, I don't see why arguments_ would
ever get set on arrow scopes. That is, why is arguments ever getting declared as
a local in an arrow scope?

[adamk, 2015/04/09 16:18:04]

Sorry, I've been spending too much time in strict code and keep forgetting how
other bits of scope resolution work. This is fine.

[arv (Not doing code reviews), 2015/04/09 16:53:07]

Changing this to a DCHECK instead.

+  }
 
   // Declarations list.
   ZoneList<Declaration*>* declarations() { return &decls_; }
 
   // Inner scope list.
   ZoneList<Scope*>* inner_scopes() { return &inner_scopes_; }
 
   // The scope immediately surrounding this scope, or NULL.
   Scope* outer_scope() const { return outer_scope_; }
 
@@ skipping 319 matching lines @@
 
   AstValueFactory* ast_value_factory_;
   Zone* zone_;
 
   PendingCompilationErrorHandler pending_error_handler_;
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_SCOPES_H_