Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: src/scopes.h

Issue 1078483002: [es6]: Lexical arguments for arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: ready Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/scopes.cc » ('j') | test/mjsunit/harmony/arrow-functions-lexical-arguments.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scopes.h
diff --git a/src/scopes.h b/src/scopes.h
index cce8c3c9eaa057558ac38bc953fe9b328719f40f..98bd0ca8987b104df8611266389b248ad2670114 100644
--- a/src/scopes.h
+++ b/src/scopes.h
@@ -394,7 +394,9 @@ class Scope: public ZoneObject {
}
// The local variable 'arguments' if we need to allocate it; NULL otherwise.
- Variable* arguments() const { return arguments_; }
+ Variable* arguments() const {
+ return is_arrow_scope() ? nullptr : arguments_;
adamk 2015/04/09 15:56:03 Why is this necessary? Reading the code again, I d
adamk 2015/04/09 16:18:04 Sorry, I've been spending too much time in strict
arv (Not doing code reviews) 2015/04/09 16:53:07 Changing this to a DCHECK instead.
+ }
// Declarations list.
ZoneList<Declaration*>* declarations() { return &decls_; }
« no previous file with comments | « no previous file | src/scopes.cc » ('j') | test/mjsunit/harmony/arrow-functions-lexical-arguments.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698