Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1078453002: Don't #define snprintf in VS2015 - it's illegal and unneeded. (Closed)

Created:
5 years, 8 months ago by brucedawson
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't #define snprintf in VS2015 - it's illegal and unneeded. VS 2015 supplies a conforming snprintf implementation, so #define snprintf is no longer needed. Also, VS 2015 checks for #define of snprintf and treats it as a fatal error. LOG=Y R=jarin@chromium.org BUG=440500 Committed: https://crrev.com/5a6247a31bdfa2b6d5cc1c436a8229458b4700d8 Cr-Commit-Position: refs/heads/master@{#27690}

Patch Set 1 #

Patch Set 2 : Don't #define snprintf in VS2015 - it's illegal and unneeded. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/ostreams.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
One small step towards building Chrome with VS 2015.
5 years, 8 months ago (2015-04-08 21:33:13 UTC) #2
Sven Panne
lgtm
5 years, 8 months ago (2015-04-09 09:00:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078453002/20001
5 years, 8 months ago (2015-04-09 09:00:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 09:02:58 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 09:03:14 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a6247a31bdfa2b6d5cc1c436a8229458b4700d8
Cr-Commit-Position: refs/heads/master@{#27690}

Powered by Google App Engine
This is Rietveld 408576698