src/ostreams.cc - Issue 1078453002: Don't #define snprintf in VS2015 - it's illegal and unneeded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ostreams.cc

Issue 1078453002: Don't #define snprintf in VS2015 - it's illegal and unneeded. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Don't #define snprintf in VS2015 - it's illegal and unneeded. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ostreams.cc

diff --git a/src/ostreams.cc b/src/ostreams.cc

index b11332dafc521f62d423890224e0d23e64e832af..c3532bdbb1412c9c3461c3980debadfa4cff42f0 100644

--- a/src/ostreams.cc

+++ b/src/ostreams.cc

@@ -5,8 +5,10 @@

#include "src/ostreams.h"

#if V8_OS_WIN

+#if _MSC_VER < 1900

#define snprintf sprintf_s

#endif

+#endif

namespace v8 {

namespace internal {

« no previous file with comments | « no previous file | no next file » | no next file with comments »