Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1078413003: Speeup hairline curves (quads and cubics) (Closed)

Created:
5 years, 8 months ago by reed1
Modified:
5 years, 8 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Speeup hairline curves (quads and cubics) /skia/trunk> cat ../old.txt maxrss loops min median mean max stddev samples config bench 9M 1 4.28ms 4.32ms 4.36ms 4.67ms 3% ▄▁▁▃▂▂▁▁▂█ 8888 path_hairline_small_AA_cubic 9M 1 743µs 767µs 770µs 825µs 4% ▃▃▇▃▁▁▅▁█▁ 8888 path_hairline_small_AA_conic 9M 1 533µs 606µs 598µs 680µs 9% ▁▂▂█▆▇▇▄▂▂ 8888 path_hairline_small_AA_quad 9M 1 451µs 452µs 456µs 495µs 3% ▁▁▁▁█▁▁▁▁▁ 8888 path_hairline_small_AA_line /skia/trunk> cat ../new.txt maxrss loops min median mean max stddev samples config bench 9M 1 827µs 827µs 831µs 869µs 2% ▁▁▁▁▁▁▁█▁▁ 8888 path_hairline_small_AA_cubic 9M 1 515µs 517µs 517µs 518µs 0% ▇█▆▅▃▃▁▁▁▅ 8888 path_hairline_small_AA_conic 9M 1 310µs 311µs 315µs 332µs 2% ▂▁█▆▁▁▁▁▁▁ 8888 path_hairline_small_AA_quad 9M 1 254µs 254µs 258µs 276µs 3% ▁▁▁▁▁▁▁█▇▂ 8888 path_hairline_small_AA_line Edited revert of https://codereview.chromium.org/1085013003 TBR= Expectations: - no effect on chrome, as it is guarded - lots of tiny rebaselines for skia

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -10 lines) Patch
M src/core/SkBlitter.h View 1 3 4 5 3 chunks +8 lines, -2 lines 0 comments Download
M src/core/SkBlitter_ARGB32.cpp View 1 3 chunks +57 lines, -0 lines 0 comments Download
M src/core/SkCoreBlitters.h View 1 3 chunks +12 lines, -0 lines 0 comments Download
M src/core/SkGeometry.h View 1 2 3 4 5 6 2 chunks +26 lines, -0 lines 0 comments Download
M src/core/SkGeometry.cpp View 1 2 3 4 5 6 4 chunks +34 lines, -0 lines 0 comments Download
M src/core/SkScan_Hairline.cpp View 1 2 3 4 5 6 7 chunks +126 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078413003/80001
5 years, 8 months ago (2015-04-15 19:27:51 UTC) #2
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-15 19:34:19 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078413003/120001
5 years, 8 months ago (2015-04-15 20:03:23 UTC) #6
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-15 20:09:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078413003/120001
5 years, 8 months ago (2015-04-15 20:13:31 UTC) #10
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://skia.googlesource.com/skia/+/a0246165eab9018d07afc09ff826ea4c40898ebc
5 years, 8 months ago (2015-04-15 20:13:52 UTC) #11
reed1
5 years, 8 months ago (2015-04-15 21:37:47 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1092483003/ by reed@google.com.

The reason for reverting is: Crazy failings in chrome tests
http://build.chromium.org/p/client.skia/builders/Linux%20Tests/builds/1862
.

Powered by Google App Engine
This is Rietveld 408576698