Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1085013003: Revert of add new blit2 methods in support of antialiased hairlines guard flag SK_SUPPORT_LEGACY_BLITANTIH2V2 (Closed)

Created:
5 years, 8 months ago by jcgregorio
Modified:
5 years, 8 months ago
Reviewers:
reed2, caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of add new blit2 methods in support of antialiased hairlines guard flag SK_SUPPORT_LEGACY_BLITANTIH2V2 (patchset #2 id:20001 of https://codereview.chromium.org/1060153003/) Reason for revert: DEPS roll is failing, one such example: http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/73847/steps/ash_unittests%20%28with%20patch%29/logs/stdio More here: https://codereview.chromium.org/1091483003 This CL was the only CL in the roll when things started to fail. Original issue's description: > add new blit2 methods in support of antialiased hairlines > > before: > 9M 1 528µs 530µs 539µs 607µs 5% ▁▁▁▁▁▁▁▁█▂ 8888 path_hairline_small_AA_quad > > after: > 9M 1 355µs 356µs 358µs 375µs 2% ▂▁▁▁▁▁▁▁▁█ 8888 path_hairline_small_AA_quad > > BUG=skia: > > does require new baselines (bug chrome is guarded) > > Committed: https://skia.googlesource.com/skia/+/dd83031b98db4c6d3d0de2353bf115152a7d1464 TBR=caryclark@google.com,reed@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/f91e676f941c7e9ec91ac298eaa32e4bf8f52762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -126 lines) Patch
M src/core/SkBlitter.h View 3 chunks +2 lines, -35 lines 0 comments Download
M src/core/SkBlitter_ARGB32.cpp View 3 chunks +0 lines, -57 lines 0 comments Download
M src/core/SkCoreBlitters.h View 3 chunks +0 lines, -12 lines 0 comments Download
M src/core/SkScan_Antihair.cpp View 2 chunks +90 lines, -22 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jcgregorio
5 years, 8 months ago (2015-04-15 13:16:53 UTC) #1
Created Revert of add new blit2 methods in support of antialiased hairlines
guard flag SK_SUPPORT_LEGACY_BLITANTIH2V2

Powered by Google App Engine
This is Rietveld 408576698