Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1078343002: Move several annotations to annotations package. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
Reviewers:
pauljensen, nyquist, Yaron
CC:
cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move several annotations to annotations package. Move AccessedByNative, CalledByNativeUnchecked and UsedByReflection to annotations package where they belond. CalledByNative and NativeCall will be moved in a separate CL since they touch every file under the sun. BUG=None Committed: https://crrev.com/9c45cf75d0438700b29211be14970d8068ca02c5 Cr-Commit-Position: refs/heads/master@{#324983}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -83 lines) Patch
D base/android/java/src/org/chromium/base/AccessedByNative.java View 1 chunk +0 lines, -20 lines 0 comments Download
D base/android/java/src/org/chromium/base/CalledByNativeUnchecked.java View 1 chunk +0 lines, -27 lines 0 comments Download
D base/android/java/src/org/chromium/base/UsedByReflection.java View 1 chunk +0 lines, -24 lines 0 comments Download
A + base/android/java/src/org/chromium/base/annotations/AccessedByNative.java View 1 chunk +1 line, -1 line 0 comments Download
A + base/android/java/src/org/chromium/base/annotations/CalledByNativeUnchecked.java View 1 chunk +1 line, -1 line 0 comments Download
A + base/android/java/src/org/chromium/base/annotations/UsedByReflection.java View 1 chunk +1 line, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/Linker.java View 1 chunk +1 line, -1 line 0 comments Download
M base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/proguard.cfg View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SmartClipProvider.java View 1 chunk +1 line, -1 line 0 comments Download
M net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
aurimas (slooooooooow)
nyquist: PTAL
5 years, 8 months ago (2015-04-10 21:51:41 UTC) #2
nyquist
lgtm
5 years, 8 months ago (2015-04-10 22:55:05 UTC) #3
aurimas (slooooooooow)
pauljensen: components/cronet/* net/* yfriedman: content/public/*
5 years, 8 months ago (2015-04-13 20:50:58 UTC) #5
pauljensen
lgtm
5 years, 8 months ago (2015-04-13 21:55:06 UTC) #6
Yaron
lgtm
5 years, 8 months ago (2015-04-13 23:45:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078343002/20001
5 years, 8 months ago (2015-04-13 23:50:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-14 01:42:12 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 01:43:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c45cf75d0438700b29211be14970d8068ca02c5
Cr-Commit-Position: refs/heads/master@{#324983}

Powered by Google App Engine
This is Rietveld 408576698