Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1078273002: Remove unnecesary ApiCompatibilityUtils calls. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
Reviewers:
Yaron, newt (away)
CC:
browser-components-watch_chromium.org, chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, estade+watch_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, posciak+watch_chromium.org, rouslan+autofillwatch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecesary ApiCompatibilityUtils calls. Since we only support API 16 now, we can drop all the workarounds for pre 16 devices. BUG=473837 TBR=yfriedman@chromium.org Committed: https://crrev.com/82aef33f7e4160c7ae578f52c8e694e91b7bb0b1 Cr-Commit-Position: refs/heads/master@{#324700}

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : newt's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -166 lines) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 4 chunks +0 lines, -128 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunView.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/AnimationHelper.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromeSwitchPreference.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java View 3 chunks +2 lines, -4 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/ColorPickerAdvancedComponent.java View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/java/src/org/chromium/ui/DropdownAdapter.java View 1 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
aurimas (slooooooooow)
newt: PTAL
5 years, 8 months ago (2015-04-10 19:13:18 UTC) #2
Evan Stade
On 2015/04/10 19:13:18, aurimas wrote: > newt: PTAL can you try to re-upload? Clicking the ...
5 years, 8 months ago (2015-04-10 19:50:44 UTC) #3
newt (away)
On 2015/04/10 19:50:44, Evan Stade wrote: > On 2015/04/10 19:13:18, aurimas wrote: > > newt: ...
5 years, 8 months ago (2015-04-10 20:01:27 UTC) #4
aurimas (slooooooooow)
On 2015/04/10 at 20:01:27, newt wrote: > On 2015/04/10 19:50:44, Evan Stade wrote: > > ...
5 years, 8 months ago (2015-04-10 20:04:57 UTC) #5
newt (away)
lgtm https://codereview.chromium.org/1078273002/diff/20001/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java File base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java (left): https://codereview.chromium.org/1078273002/diff/20001/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java#oldcode326 base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java:326: public static void setBackgroundForView(View view, Drawable drawable) { ...
5 years, 8 months ago (2015-04-10 21:08:01 UTC) #6
aurimas (slooooooooow)
https://codereview.chromium.org/1078273002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java File chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java (right): https://codereview.chromium.org/1078273002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java#newcode67 chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java:67: SmoothProgressBar.this.postOnAnimationDelayed(this, PROGRESS_UPDATE_DELAY_MS); On 2015/04/10 at 21:08:01, newt wrote: > ...
5 years, 8 months ago (2015-04-10 21:12:54 UTC) #7
aurimas (slooooooooow)
yfriedman@ TBR for base/android/java
5 years, 8 months ago (2015-04-10 21:16:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078273002/40001
5 years, 8 months ago (2015-04-10 21:19:25 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-10 22:42:06 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 22:42:54 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/82aef33f7e4160c7ae578f52c8e694e91b7bb0b1
Cr-Commit-Position: refs/heads/master@{#324700}

Powered by Google App Engine
This is Rietveld 408576698