chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java - Issue 1078273002: Remove unnecesary ApiCompatibilityUtils calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java

Issue 1078273002: Remove unnecesary ApiCompatibilityUtils calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: newt's comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromeSwitchPreference.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java

index 3ce2f5232be78c2123f35d209c293445ba8aa22e..5591e6db45c39355daab374a198bbcab55700828 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/NotificationTransportControl.java

@@ -19,7 +19,6 @@ import android.util.DisplayMetrics;

import android.view.View;

import android.widget.RemoteViews;

-import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.media.remote.RemoteVideoInfo.PlayerState;

@@ -577,8 +576,7 @@ public class NotificationTransportControl

videoInfo.currentTimeMillis, false);

contentView.setImageViewResource(R.id.playpause,

R.drawable.ic_vidcontrol_pause);

- ApiCompatibilityUtils.setContentDescriptionForRemoteView(contentView,

- R.id.playpause, mPauseDescription);

+ contentView.setContentDescription(R.id.playpause, mPauseDescription);

contentView.setOnClickPendingIntent(R.id.playpause,

getService().getPendingIntent(ListenerService.ACTION_ID_PAUSE));

break;

@@ -588,8 +586,7 @@ public class NotificationTransportControl

contentView.setProgressBar(R.id.progress, videoInfo.durationMillis,

videoInfo.currentTimeMillis, false);

contentView.setImageViewResource(R.id.playpause, R.drawable.ic_vidcontrol_play);

- ApiCompatibilityUtils.setContentDescriptionForRemoteView(contentView,

- R.id.playpause, mPlayDescription);

+ contentView.setContentDescription(R.id.playpause, mPlayDescription);

contentView.setOnClickPendingIntent(R.id.playpause,

getService().getPendingIntent(ListenerService.ACTION_ID_PLAY));

break;