Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 1077763002: Change some more GMs to clear to opaque black, not transparent black. (Closed)

Created:
5 years, 8 months ago by Stephen White
Modified:
5 years, 8 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change some more GMs to clear to opaque black, not transparent black. N.B.: this will change results on the bots for all the tests modified. BUG=skia:3319 Committed: https://skia.googlesource.com/skia/+/16b254a200f63e85041cac9a283ff0ff14d94ba1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M gm/displacement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersclipped.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/matrixconvolution.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/matriximagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/offsetimagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/perlinnoise.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/resizeimagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/tileimagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/xfermodeimagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Stephen White
scroggo@: PTAL. Thanks!
5 years, 8 months ago (2015-04-09 18:03:47 UTC) #2
scroggo
On 2015/04/09 18:03:47, Stephen White wrote: > scroggo@: PTAL. Thanks! LGTM
5 years, 8 months ago (2015-04-09 18:04:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077763002/1
5 years, 8 months ago (2015-04-09 18:05:22 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 18:13:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/16b254a200f63e85041cac9a283ff0ff14d94ba1

Powered by Google App Engine
This is Rietveld 408576698