Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1077433003: Revert of cc: Re-use transforms from transform nodes when computing visible rects (Closed)

Created:
5 years, 8 months ago by ajuma
Modified:
5 years, 8 months ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, cc-bugs_chromium.org, cbiesinger
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Re-use transforms from transform nodes when computing visible rects (patchset #2 id:20001 of https://codereview.chromium.org/1060413002/) Reason for revert: Causes css3/filters/effect-reference-hidpi-hw.html to have an incorrect visible rect. Original issue's description: > cc: Re-use transforms from transform nodes when computing visible rects > > This makes CalculateVisibleRects try to re-use the to_target and > from_target transforms stored in transform nodes whenever it needs to > compute a transform. Since these baked transforms incorporate the > target's sublayer scale, the fallback path now also includes sublayer > scale for consistency. > > Testing locally on a z620, this improves property tree computation time > by 7% on Gmail, and by 20% on rAF-driven poster circle. > > BUG=474725 > > Committed: https://crrev.com/992c398b2fb0e7ab9c7ba58a8eb36787e03962e4 > Cr-Commit-Position: refs/heads/master@{#324122} TBR=vollick@chromium.org BUG=474725 Committed: https://crrev.com/fa14fd7f3167d2c33a7978b4e8d7bf36b67639d7 Cr-Commit-Position: refs/heads/master@{#324326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -26 lines) Patch
M cc/trees/draw_property_utils.cc View 3 chunks +10 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ajuma
Created Revert of cc: Re-use transforms from transform nodes when computing visible rects
5 years, 8 months ago (2015-04-08 21:49:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077433003/1
5 years, 8 months ago (2015-04-08 21:50:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 01:03:12 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 01:05:28 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa14fd7f3167d2c33a7978b4e8d7bf36b67639d7
Cr-Commit-Position: refs/heads/master@{#324326}

Powered by Google App Engine
This is Rietveld 408576698