Issue 1077153005: Allow eval/arguments in arrow functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1077153005: Allow eval/arguments in arrow functions (Closed)

Created:
5 years, 8 months ago by wingo

Modified:
5 years, 8 months ago

Reviewers:
marja

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Allow eval/arguments in arrow functions Originally landed in https://codereview.chromium.org/1061983004; re-landing after re-landing formal parameter parsing refactors. R=marja@chromium.org BUG=v8:4020 LOG=N Committed: https://crrev.com/8be0499fced0c41fa2c00a4b53d234413941f056 Cr-Commit-Position: refs/heads/master@{#27971}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+287 lines, -196 lines)			Patch
M	src/messages.js	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/parser.h	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/parser.cc	View	4 chunks	+116 lines, -92 lines	0 comments	Download
M	src/preparser.h	View	19 chunks	+83 lines, -81 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	2 chunks	+77 lines, -14 lines	0 comments	Download

Total messages: 6 (1 generated)

wingo

PTAL when https://codereview.chromium.org/1100713002/ lands and we verify that it doesn't break the perf bots. Thanks!

5 years, 8 months ago (2015-04-21 10:44:28 UTC) #1

marja

lgtm based on the previous version, as the changes are straightforward.

5 years, 8 months ago (2015-04-21 12:11:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077153005/1

5 years, 8 months ago (2015-04-21 14:19:52 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-22 04:10:18 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8be0499fced0c41fa2c00a4b53d234413941f056
Cr-Commit-Position: refs/heads/master@{#27971}