Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: src/parser.h

Issue 1077153005: Allow eval/arguments in arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/messages.js ('k') | src/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.h
diff --git a/src/parser.h b/src/parser.h
index a985d71e984aad23a1ae14fab423dc2eaf54b965..3b3144e0619f37e2d3d1e80703bcdbbcb46fd664 100644
--- a/src/parser.h
+++ b/src/parser.h
@@ -696,7 +696,6 @@ class ParserTraits {
static Expression* EmptyExpression() {
return NULL;
}
- static Expression* EmptyArrowParamList() { return NULL; }
static Literal* EmptyLiteral() {
return NULL;
}
@@ -746,11 +745,6 @@ class ParserTraits {
V8_INLINE Scope* NewScope(Scope* parent_scope, ScopeType scope_type,
FunctionKind kind = kNormalFunction);
- // Utility functions
- int DeclareArrowParametersFromExpression(Expression* expression, Scope* scope,
- FormalParameterErrorLocations* locs,
- bool* ok);
-
bool DeclareFormalParameter(Scope* scope, const AstRawString* name,
bool is_rest) {
bool is_duplicate = false;
@@ -764,6 +758,14 @@ class ParserTraits {
return is_duplicate;
}
+ void DeclareArrowFunctionParameters(Scope* scope, Expression* expr,
+ const Scanner::Location& params_loc,
+ FormalParameterErrorLocations* error_locs,
+ bool* ok);
+ void ParseArrowFunctionFormalParameters(
+ Scope* scope, Expression* params, const Scanner::Location& params_loc,
+ FormalParameterErrorLocations* error_locs, bool* is_rest, bool* ok);
+
// Temporary glue; these functions will move to ParserBase.
Expression* ParseV8Intrinsic(bool* ok);
FunctionLiteral* ParseFunctionLiteral(
@@ -1060,8 +1062,6 @@ class Parser : public ParserBase<ParserTraits> {
ScriptCompiler::CompileOptions compile_options_;
ParseData* cached_parse_data_;
- bool parsing_lazy_arrow_parameters_; // for lazily parsed arrow functions.
-
PendingCompilationErrorHandler pending_error_handler_;
// Other information which will be stored in Parser and moved to Isolate after
« no previous file with comments | « src/messages.js ('k') | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698