Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1077113002: Treat HArgumentsObject as a safe use during Uint32 analysis phase. (Closed)

Created:
5 years, 8 months ago by Vyacheslav Egorov (Google)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Treat HArgumentsObject as a safe use during Uint32 analysis phase. Deoptimization infrastructure already handles it correctly. This change fixes repetitive deoptimizations in the code like this: var u32 = new Uint32Array(1); u32[0] = -1; function tr(x) { return x|0; } function ld() { return tr(u32[0]); } while (true) ld(); Currently inlined tr will contain HArgumentsObject that is considered uint32-unsafe use and prevents u32[0] from becoming uint32 load - instead a speculative int32 load is generated which just deopts. BUG= Committed: https://crrev.com/021f738127406ef6ff8868465ff32b59edaff016 Cr-Commit-Position: refs/heads/master@{#27781}

Patch Set 1 #

Patch Set 2 : remove assertOptimized #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M src/deoptimizer.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/hydrogen-uint32-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/uint32.js View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Vyacheslav Egorov (Google)
Hi Jakob & Michael! Here is a blast from the past. Could you take a ...
5 years, 8 months ago (2015-04-10 12:04:00 UTC) #2
Jakob Kummerow
LGTM.
5 years, 8 months ago (2015-04-10 12:15:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1077113002/20001
5 years, 8 months ago (2015-04-13 10:25:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-13 10:47:24 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 10:47:38 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/021f738127406ef6ff8868465ff32b59edaff016
Cr-Commit-Position: refs/heads/master@{#27781}

Powered by Google App Engine
This is Rietveld 408576698